content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 848653002: Re-land: Send Windows accessibility events based on tree updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 848653002: Re-land: Send Windows accessibility events based on tree updates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@implicit_1_tests

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/browser_accessibility_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index dd3daeb708ae7ca53fee6594de7b3bf4c8c34c11..b6f58df044fc51f8c58a13dc56c6b2e67b010dd8 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -482,7 +482,9 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSNumber*)numberOfCharacters {

- return [NSNumber numberWithInt:browserAccessibility_->value().length()];

+ std::string value = browserAccessibility_->GetStringAttribute(

+ ui::AX_ATTR_VALUE);

+ return [NSNumber numberWithInt:value.size()];

}

// The origin of this accessibility object in the page's document.

@@ -918,8 +920,9 @@ NSDictionary* attributeToMethodNameMap = nil;

}

- (NSValue*)visibleCharacterRange {

- return [NSValue valueWithRange:

- NSMakeRange(0, browserAccessibility_->value().length())];

+ std::string value = browserAccessibility_->GetStringAttribute(

+ ui::AX_ATTR_VALUE);

+ return [NSValue valueWithRange:NSMakeRange(0, value.size())];

}

- (NSArray*)visibleCells {

@@ -1033,7 +1036,9 @@ NSDictionary* attributeToMethodNameMap = nil;

const std::vector<int32>& line_breaks =

browserAccessibility_->GetIntListAttribute(

ui::AX_ATTR_LINE_BREAKS);

- int len = static_cast<int>(browserAccessibility_->value().size());

+ std::string value = browserAccessibility_->GetStringAttribute(

+ ui::AX_ATTR_VALUE);

+ int len = static_cast<int>(value.size());

if ([attribute isEqualToString:

NSAccessibilityStringForRangeParameterizedAttribute]) {