Issue 8486025: Remove the ability to set the default search engine from JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8486025: Remove the ability to set the default search engine from JS. (Closed)

Created:
9 years, 1 month ago by levin

Modified:
9 years, 1 month ago

Reviewers:
Dmitry Titov

CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the ability to set the default search engine from JS. Enable isSearchProviderInstalled from the HTML 5 spec for all platforms http://dev.w3.org/html5/spec-author-view/system-state-and-capabilities.html#dom-external-issearchproviderinstalled There is still some clean to do after this to remove now dead code and strings, but this does the externally visible part. BUG=100946 TEST=SearchProviderTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110559

Patch Set 1 #

Patch Set 2 : fix build #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -42 lines)			Patch
	M	chrome/renderer/external_extension.cc	View	1	3 chunks	+7 lines, -39 lines	0 comments	Download
	M	chrome/renderer/external_extension_uitest.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/levin@chromium.org/8486025/2001

9 years, 1 month ago (2011-11-17 19:57:21 UTC) #3

Change committed as 110559

Expand Messages | Collapse Messages