Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 848513004: Mojo JS Bindings: URL class (Closed)

Created:
5 years, 11 months ago by hansmuller
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojo JS Bindings: URL class Made a copy of the Node.js URL class in third_party/js. JS applications often have to manipulate URLs and string hacking gets old fast. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b821f93b20214b6581f1634f02abf1f989251803

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1540 lines, -18 lines) Patch
M examples/js/show_image.js View 1 chunk +7 lines, -18 lines 0 comments Download
A third_party/js/README.md View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/js/punycode.js View 1 1 chunk +497 lines, -0 lines 0 comments Download
A third_party/js/querystring.js View 1 chunk +227 lines, -0 lines 0 comments Download
A third_party/js/url.js View 1 chunk +730 lines, -0 lines 0 comments Download
A third_party/js/util.js View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/848513004/diff/1/third_party/js/punycode.js File third_party/js/punycode.js (right): https://codereview.chromium.org/848513004/diff/1/third_party/js/punycode.js#newcode1 third_party/js/punycode.js:1: /*! http://mths.be/punycode v1.2.3 by @mathias */ Is there ...
5 years, 11 months ago (2015-01-13 20:32:35 UTC) #2
hansmuller1
On 2015/01/13 20:32:35, abarth wrote: > lgtm > > https://codereview.chromium.org/848513004/diff/1/third_party/js/punycode.js > File third_party/js/punycode.js (right): > ...
5 years, 11 months ago (2015-01-13 20:42:15 UTC) #3
hansmuller
5 years, 11 months ago (2015-01-13 20:43:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b821f93b20214b6581f1634f02abf1f989251803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698