Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 848503003: Fix printing of logged non-ascii characters (Closed)

Created:
5 years, 11 months ago by cjhopman
Modified:
5 years, 11 months ago
Reviewers:
mdjones
Base URL:
https://code.google.com/p/dom-distiller/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix printing of logged non-ascii characters webdriver seems to not handle non-ascii characters in the result of an executed script correctly (python throws an exception when printing the string). This makes them be printed correctly. R=mdjones@chromium.org Committed: 2fda06e11c9b536a5771d5b7f4fb31e5c20223a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M run_jstests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
cjhopman
mdjones: *
5 years, 11 months ago (2015-01-10 02:01:30 UTC) #2
mdjones
lgtm
5 years, 11 months ago (2015-01-10 02:16:39 UTC) #3
cjhopman
5 years, 11 months ago (2015-01-13 02:18:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2fda06e11c9b536a5771d5b7f4fb31e5c20223a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698