Improve script to find user actions.

tools/metrics/actions/extract_actions_test.py

Index: tools/metrics/actions/extract_actions_test.py
diff --git a/tools/metrics/actions/extract_actions_test.py b/tools/metrics/actions/extract_actions_test.py
index a5cfd387717a1b2498ebdc099c991e5e0d8611be..2860693f7e19b1a6bd647161c6a80b6966ac29a7 100755
--- a/tools/metrics/actions/extract_actions_test.py
+++ b/tools/metrics/actions/extract_actions_test.py
@@ -114,7 +114,6 @@ COMMENT_EXPECTED_XML = (
     '</actions>\n'
 )
 
-
 class ActionXmlTest(unittest.TestCase):
 
   def _GetProcessedAction(self, owner, description, obsolete, new_actions=[],
@@ -194,6 +193,38 @@ class ActionXmlTest(unittest.TestCase):
                                           comment=COMMENT)
     self.assertEqual(COMMENT_EXPECTED_XML, xml_result)
 
+  def testUserMetricsActionSpanningTwoLines(self):
+    code = 'base::UserMetricsAction(\n"Foo.Bar"));'
+    finder = extract_actions.ActionNameFinder('dummy', code)
+    self.assertEqual('Foo.Bar', finder.FindNextAction())
+    self.assertFalse(finder.FindNextAction())
+
+  def testUserMetricsActionAsAParam(self):
+    code = 'base::UserMetricsAction("Test.Foo"), "Test.Bar");'
+    finder = extract_actions.ActionNameFinder('dummy', code)
+    self.assertEqual('Test.Foo', finder.FindNextAction())
+    self.assertFalse(finder.FindNextAction())
+
+  def testNonLiteralUserMetricsAction(self):
+    code = 'base::UserMetricsAction(FOO)'
+    finder = extract_actions.ActionNameFinder('dummy', code)
+    with self.assertRaises(Exception):
+      finder.FindNextAction()
+
+  def testTernaryUserMetricsAction(self):
+    code = 'base::UserMetricsAction(foo ? "Foo.Bar" : "Bar.Foo"));'
+    finder = extract_actions.ActionNameFinder('dummy', code)
+    with self.assertRaises(Exception):
+      finder.FindNextAction()
+
+  def testTernaryUserMetricsActionWithNewLines(self):
+    code = """base::UserMetricsAction(
+      foo_bar ? "Bar.Foo" :
+      "Foo.Car")"""
+    finder = extract_actions.ActionNameFinder('dummy', code)
+    with self.assertRaises(extract_actions.InvalidStatementException):
+      finder.FindNextAction()
+
 
 if __name__ == '__main__':
   unittest.main()