Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 848443002: Fix v8 external snapshot code for Windows. (Closed)

Created:
5 years, 11 months ago by rmcilroy
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M samples/pdfium_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
rmcilroy
Raymes, PTAL, thanks.
5 years, 11 months ago (2015-01-09 21:23:31 UTC) #2
rmcilroy
thestig / tsepez: PTAL, thanks. This is required to land https://codereview.chromium.org/826083004/ which enables the external ...
5 years, 11 months ago (2015-01-12 18:22:38 UTC) #4
Tom Sepez
https://codereview.chromium.org/848443002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/848443002/diff/1/samples/pdfium_test.cc#newcode108 samples/pdfium_test.cc:108: result_data->raw_size = static_cast<int>data_length; Typo: missing parens, eg. static_cast<int>(data_length)
5 years, 11 months ago (2015-01-12 18:28:10 UTC) #5
rmcilroy
https://codereview.chromium.org/848443002/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/848443002/diff/1/samples/pdfium_test.cc#newcode108 samples/pdfium_test.cc:108: result_data->raw_size = static_cast<int>data_length; On 2015/01/12 18:28:09, Tom Sepez wrote: ...
5 years, 11 months ago (2015-01-12 20:09:12 UTC) #6
Tom Sepez
lgtm
5 years, 11 months ago (2015-01-12 20:18:45 UTC) #7
rmcilroy
On 2015/01/12 20:18:45, Tom Sepez wrote: > lgtm Thanks Tom! Could you land this please? ...
5 years, 11 months ago (2015-01-12 21:08:50 UTC) #8
rmcilroy
On 2015/01/12 21:08:50, rmcilroy wrote: > On 2015/01/12 20:18:45, Tom Sepez wrote: > > lgtm ...
5 years, 11 months ago (2015-01-14 11:06:50 UTC) #9
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-14 12:05:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f731837225b825e154d6b1664160ed6f70d451ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698