Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: sdk/lib/_internal/pub/lib/src/source/git.dart

Issue 848363003: Remove some unnecessary logs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/source/git.dart
diff --git a/sdk/lib/_internal/pub/lib/src/source/git.dart b/sdk/lib/_internal/pub/lib/src/source/git.dart
index 89653e1d28f7b3df740fdfbdb3430a6f3c792262..dc4c8b3e8a413a209474dc8b1b1431f851735885 100644
--- a/sdk/lib/_internal/pub/lib/src/source/git.dart
+++ b/sdk/lib/_internal/pub/lib/src/source/git.dart
@@ -214,9 +214,7 @@ class GitSource extends CachedSource {
Future<String> _ensureRevision(PackageId id) {
return new Future.sync(() {
var path = _repoCachePath(id);
- log.fine("ensuring $path has ${id.description}");
if (!entryExists(path)) {
- log.fine("$path doesn't exist");
return _clone(_getUrl(id), path, mirror: true)
.then((_) => _getRev(id));
}
@@ -225,18 +223,13 @@ class GitSource extends CachedSource {
// reference. We want to get the latest version of that reference.
var description = id.description;
if (description is! Map || !description.containsKey('resolved-ref')) {
- log.fine("ID doesn't have a resolved ref");
return _updateRepoCache(id).then((_) => _getRev(id));
}
// If [id] did come from a lockfile, then we want to avoid running "git
// fetch" if possible to avoid networking time and errors. See if the
// revision exists in the repo cache before updating it.
- return _getRev(id).then((res) {
- log.fine("ref is $res");
- return res;
- }).catchError((error) {
- log.fine("repo doesn't have ref, updating");
+ return _getRev(id).catchError((error) {
if (error is! git.GitException) throw error;
return _updateRepoCache(id).then((_) => _getRev(id));
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698