Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 84833006: Add Isolate* parameter to static API methods that don't take one. (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add Isolate* parameter to static API methods that don't take one. We cannot yet deprecate the versions that don't take one, because there's too much test code in v8 using them. To keep this CL small and managable, I'll first introduce the new APIs. BUG=none R=dcarney@chromium.org, svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18068

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -100 lines) Patch
M include/v8.h View 1 2 20 chunks +67 lines, -9 lines 0 comments Download
M src/api.cc View 1 2 17 chunks +193 lines, -90 lines 0 comments Download
M src/full-codegen.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-11-25 15:27:52 UTC) #1
dcarney
lgtm https://codereview.chromium.org/84833006/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/84833006/diff/1/include/v8.h#newcode1141 include/v8.h:1141: // Will be deprecated soon. maybe move to ...
7 years ago (2013-11-25 15:35:52 UTC) #2
Sven Panne
LGTM with a nit. Furthermore (as discussed offline), we might consider changing all those class ...
7 years ago (2013-11-26 08:57:39 UTC) #3
dcarney
On 2013/11/26 08:57:39, Sven Panne wrote: > LGTM with a nit. Furthermore (as discussed offline), ...
7 years ago (2013-11-26 09:35:54 UTC) #4
jochen (gone - plz use gerrit)
7 years ago (2013-11-26 09:45:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r18068.

Powered by Google App Engine
This is Rietveld 408576698