Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 848213003: JS Mojo Geocoder Demo (Closed)

Created:
5 years, 11 months ago by hansmuller
Modified:
5 years, 11 months ago
Reviewers:
hansmuller1, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

JS Mojo Geocoder Demo Added a JS example that demos encapsulating Google's geocoder web service with a Mojo application. BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05250719ab0fa9ea79d2e59ffd77351d71831a48

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -7 lines) Patch
M examples/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M examples/js/README.md View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + examples/js/maps/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
A examples/js/maps/demo.js View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
A examples/js/maps/geocoder.mojom View 1 chunk +68 lines, -0 lines 0 comments Download
A examples/js/maps/geocoder_service.js View 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hansmuller1
PTAL
5 years, 11 months ago (2015-01-15 01:16:55 UTC) #4
eseidel
lgtm
5 years, 11 months ago (2015-01-15 18:33:36 UTC) #5
hansmuller
5 years, 11 months ago (2015-01-15 19:19:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
05250719ab0fa9ea79d2e59ffd77351d71831a48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698