Subzero: Add locking to prepare for multithreaded translation.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 482844f56412748855ad9f4ca8a7d08765fffe37..b5e78ade19ade70ec260c7179cfa787b04271675 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -166,6 +166,8 @@ public:
       : NaClBitcodeParser(Cursor), Translator(Translator), Header(Header),
         ErrorStatus(ErrorStatus), NumErrors(0), NumFunctionIds(0),
         NumFunctionBlocks(0), BlockParser(nullptr) {
+    // Note: This gives the reader wild access to the stream.

[jvoung (off chromium), 2015/01/15 18:20:40]

What does "wild" access mean? =)

[Jim Stichnoth, 2015/01/17 18:44:17]

Clarified the comment - it means the stream is being stashed somewhere and can
be improperly used without locking.  Added a TODO for Karl about possibly
changing the LLVM-side interface.

+    Ice::OstreamLocker L(Translator.getContext());
     setErrStream(Translator.getContext()->getStrDump());
   }
 
@@ -2814,8 +2816,7 @@ private:
       Decl->setName(Trans.createUnnamedName(Prefix, NameIndex));
       ++NameIndex;
     } else {
-      Trans.checkIfUnnamedNameSafe(Decl->getName(), Context, Prefix,
-                                   Trans.getContext()->getStrDump());
+      Trans.checkIfUnnamedNameSafe(Decl->getName(), Context, Prefix);
     }
   }