Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceConverter.cpp

Issue 848193003: Subzero: Add locking to prepare for multithreaded translation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceDefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceConverter.cpp
diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp
index cdfdc43580eb686134eba45e9e349794c15dd99d..72f5a5a9d78f46a1fa952165f24ab87eb17a3231 100644
--- a/src/IceConverter.cpp
+++ b/src/IceConverter.cpp
@@ -793,13 +793,12 @@ void Converter::nameUnnamedGlobalVariables(Module *Mod) {
if (GlobalPrefix.empty())
return;
uint32_t NameIndex = 0;
- Ostream &errs = Ctx->getStrDump();
for (auto V = Mod->global_begin(), E = Mod->global_end(); V != E; ++V) {
if (!V->hasName()) {
V->setName(createUnnamedName(GlobalPrefix, NameIndex));
++NameIndex;
} else {
- checkIfUnnamedNameSafe(V->getName(), "global", GlobalPrefix, errs);
+ checkIfUnnamedNameSafe(V->getName(), "global", GlobalPrefix);
}
}
}
@@ -809,13 +808,12 @@ void Converter::nameUnnamedFunctions(Module *Mod) {
if (FunctionPrefix.empty())
return;
uint32_t NameIndex = 0;
- Ostream &errs = Ctx->getStrDump();
for (Function &F : *Mod) {
if (!F.hasName()) {
F.setName(createUnnamedName(FunctionPrefix, NameIndex));
++NameIndex;
} else {
- checkIfUnnamedNameSafe(F.getName(), "function", FunctionPrefix, errs);
+ checkIfUnnamedNameSafe(F.getName(), "function", FunctionPrefix);
}
}
}
« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceDefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698