LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestEventTarget-interface-is-visible.html - Issue 848173003: Dropping [NoInterfaceObject] from XMLHttpRequestEventTarget

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestEventTarget-interface-is-visible.html

Issue 848173003: Dropping [NoInterfaceObject] from XMLHttpRequestEventTarget (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="/js-test-resources/js-test.js"></script>

	4

	5 <script>

	6 description("The XMLHttpRequestEventTarget is visible to the script");

	7

	8 objXmlHttpEventTarget = new XMLHttpRequest;

	9 shouldBeTrue("objXmlHttpEventTarget instanceof XMLHttpRequestEventTarget", true) ;
	sof 2015/01/30 19:02:10 Could you add a line to fast/js/script-tests/insta Could you add a line to fast/js/script-tests/instanceof-XMLHttpRequest.js instead? http/tests/xmlhttprequest is preferably only used for XHR tests that require network traffix, which this one doesn't. If you want to go even better, then splitting out the XMLHttpRequest instanceof tests from instanceof-*.js in fast/js/ and make a new test in fast/xmlhttprequest/ would be even better, as fast/js/ is a bit unfocused and not a directory we try add even more tests to. I won't insist on that last part (but it would be nice.. :) ), but at least these instanceof tests should be kept together (and outside http/.)
	10 </script>

	11 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestEventTarget-interface-is-visible-expected.txt » ('j') | no next file with comments »