Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 848163002: [New Multicolumn] Clip correctly if the "root" layer is inside the multicol container. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Clip correctly if the "root" layer is inside the multicol container. When the "root" layer is inside the multicol container, don't get lost and make the clip rectangle relative to the RenderView. It needs to be relative to the "root" layer. When compositing, the "root" layer could be the very same as the layer being painted. BUG=359877 R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/multicol/composited-relpos-in-clipped.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/multicol/composited-relpos-in-clipped-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-14 10:14:21 UTC) #1
chrishtr
lgtm
5 years, 11 months ago (2015-01-16 18:40:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848163002/1
5 years, 11 months ago (2015-01-16 18:41:32 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 22:08:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188552

Powered by Google App Engine
This is Rietveld 408576698