Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 848153005: Revert of mac: Implement custom AppKit Enter Fullscreen transition. (Closed)

Created:
5 years, 11 months ago by maniscalco
Modified:
5 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Implement custom AppKit Enter Fullscreen transition. (patchset #6 id:240001 of https://codereview.chromium.org/846443004/) Reason for revert: Trying to track down a sizes failure. Speculatively reverting. Will re-apply if not the cause. Original issue's description: > mac: Implement custom AppKit Enter Fullscreen transition. > > AppKit's default Fullscreen transition cross-fades between two static images: a > snapshot of the window before the transition began, and a snapshot of the > window resized to the full size of the screen. This has the problem that > frequently, when AppKit takes the snapshot of the final state of the window, > the web contents view has not yet drawn any content in the new size. The > animation itself looks weird, and then there's a flash when the animation > finishes where the snapshot of the old web content is replaced by the new web > content. > > This custom fullscreen transition is very similar, except instead of taking a > snapshot of the window in its final state, the transition uses a live version > of the window in its final state. See the associated bug for more details about > the implementation. > > BUG=414527 > > Committed: https://crrev.com/a48cbbba0075b7a7c135605ab576bad2cfa5a1b3 > Cr-Commit-Position: refs/heads/master@{#311717} TBR=andresantoso@chromium.org,rsesek@chromium.org,mark@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=414527, 449333 Committed: https://crrev.com/3e9e697cec99343b2e85f54a0b7a4e9932415233 Cr-Commit-Position: refs/heads/master@{#311768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -481 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 4 chunks +4 lines, -56 lines 0 comments Download
D chrome/browser/ui/cocoa/browser_window_enter_fullscreen_transition.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/ui/cocoa/browser_window_enter_fullscreen_transition.mm View 1 chunk +0 lines, -302 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of mac: Implement custom AppKit Enter Fullscreen transition.
5 years, 11 months ago (2015-01-15 23:32:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848153005/1
5 years, 11 months ago (2015-01-15 23:34:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:36:31 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:37:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e9e697cec99343b2e85f54a0b7a4e9932415233
Cr-Commit-Position: refs/heads/master@{#311768}

Powered by Google App Engine
This is Rietveld 408576698