Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 848103002: AreDataReductionProxiesBypassed should use the DRP config (Closed)

Created:
5 years, 11 months ago by megjablon
Modified:
5 years, 11 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AreDataReductionProxiesBypassed should use the DRP config With the changes to make the Data Reduction Proxy a best effort proxy, AreDataReductionProxiesBypassed should take the Data Reduction Proxy config rather than use the request's proxy service config. BUG=448477 Committed: https://crrev.com/abc858dfc54049ca59619ab0f27b98818b69be30 Cr-Commit-Position: refs/heads/master@{#311580}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Patch Set 3 : Fixing DRPNetworkDelegate test #

Total comments: 1

Patch Set 4 : Removing scoped ptr #

Patch Set 5 : Rebase #

Messages

Total messages: 10 (4 generated)
megjablon
5 years, 11 months ago (2015-01-13 21:28:55 UTC) #2
bengr
lgtm with nit https://codereview.chromium.org/848103002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc (right): https://codereview.chromium.org/848103002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc#newcode197 components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc:197: !proxy_config_getter_.is_null()) { // Need for request ...
5 years, 11 months ago (2015-01-14 20:01:51 UTC) #3
bengr
https://codereview.chromium.org/848103002/diff/60001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc (right): https://codereview.chromium.org/848103002/diff/60001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc#newcode124 components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:124: scoped_ptr<net::ProxyConfig> config_; Does this need to be a scoped_ptr?
5 years, 11 months ago (2015-01-14 21:59:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848103002/120001
5 years, 11 months ago (2015-01-15 00:03:37 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years, 11 months ago (2015-01-15 00:07:37 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:08:42 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/abc858dfc54049ca59619ab0f27b98818b69be30
Cr-Commit-Position: refs/heads/master@{#311580}

Powered by Google App Engine
This is Rietveld 408576698