Source/web/FrameLoaderClientImpl.cpp - Issue 848053002: Adding WebVR interface to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 848053002: Adding WebVR interface to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed sigbjornf@'s epic amount of feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 706b4b622586cadc904d4564a73962bc2aa981a7..984b88fc89de3169393815cb7d2661fd20b9814e 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -56,6 +56,7 @@

#include "modules/device_orientation/DeviceOrientationController.h"

#include "modules/gamepad/NavigatorGamepad.h"

#include "modules/serviceworkers/NavigatorServiceWorker.h"

+#include "modules/vr/NavigatorVRDevice.h"

#include "platform/MIMETypeRegistry.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/UserGestureIndicator.h"

@@ -130,6 +131,8 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()

if (RuntimeEnabledFeatures::serviceWorkerEnabled())

NavigatorServiceWorker::from(*document);

DOMWindowStorageController::from(*document);

+ if (RuntimeEnabledFeatures::vRDeviceEnabled())

+ NavigatorVRDevice::from(*document);

}

// FIXME: when extensions go out of process, this whole concept stops working.