Source/web/FrameLoaderClientImpl.cpp - Issue 848053002: Adding WebVR interface to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 848053002: Adding WebVR interface to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed feedback from philipj@opera.com, rebased Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 706b4b622586cadc904d4564a73962bc2aa981a7..1ab4a5fe79dcf99b2be2a1b3281ae49c91b14feb 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -56,6 +56,7 @@

#include "modules/device_orientation/DeviceOrientationController.h"

#include "modules/gamepad/NavigatorGamepad.h"

#include "modules/serviceworkers/NavigatorServiceWorker.h"

+#include "modules/vr/NavigatorVRDevice.h"

#include "platform/MIMETypeRegistry.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/UserGestureIndicator.h"

@@ -127,6 +128,7 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()

if (RuntimeEnabledFeatures::deviceLightEnabled())

DeviceLightController::from(*document);

NavigatorGamepad::from(*document);

+ NavigatorVRDevice::from(*document);

sof 2015/02/24 12:35:29 Doesn't this need to be conditionally enabled?

if (RuntimeEnabledFeatures::serviceWorkerEnabled())

NavigatorServiceWorker::from(*document);

DOMWindowStorageController::from(*document);