Source/modules/vr/PositionSensorVRDevice.idl - Issue 848053002: Adding WebVR interface to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/vr/PositionSensorVRDevice.idl

Issue 848053002: Adding WebVR interface to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Iterable,	6 RuntimeEnabled=VRDevice,

7 GarbageCollected,	7 GarbageCollected,

8 NoInterfaceObject,	8 ] interface PositionSensorVRDevice : VRDevice {

9 ] interface Iterator {	9 VRPositionState getState(optional double timeOffset);

10 [CallWith=ScriptState, RaisesException] any next(optional any value);	10 void zeroSensor();
	philipj_slow 2015/02/06 01:57:14 zero is an odd verb, and apparently you agree sinc zero is an odd verb, and apparently you agree since you called it reset internally. Change the spec to resetSensor, clearSensor, or something? philipj_slow 2015/02/23 02:33:10 resetSensor() it is. Show quoted text On 2015/02/06 01:57:14, philipj_UTC7 wrote: > zero is an odd verb, and apparently you agree since you called it reset > internally. Change the spec to resetSensor, clearSensor, or something? resetSensor() it is.
11 };	11 };

OLD	NEW