Source/modules/vr/HMDVRDevice.idl - Issue 848053002: Adding WebVR interface to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/vr/HMDVRDevice.idl

Issue 848053002: Adding WebVR interface to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 enum VREye {

	6 "left",

	7 "right"

	8 };

	9

	10 [

	11 RuntimeEnabled=VRDevice,

	12 GarbageCollected,
	philipj_slow 2015/02/06 01:57:14 Add TypeChecking=Interface to all interfaces where Add TypeChecking=Interface to all interfaces where it would make a difference, so that you'll get a TypeError for setFieldOfView(window) for example.
	13 ] interface HMDVRDevice : VRDevice {

	14 DOMPoint getEyeTranslation(VREye whichEye);
	philipj_slow 2015/02/06 01:57:14 I guess you know about https://groups.google.com/a I guess you know about https://groups.google.com/a/chromium.org/d/msg/blink-dev/V_bJNtOg0oM/o4Mi41Yx... ?
	15 VRFieldOfView getCurrentEyeFieldOfView(VREye whichEye);

	16 VRFieldOfView getRecommendedEyeFieldOfView(VREye whichEye);

	17 VRFieldOfView getMaximumEyeFieldOfView(VREye whichEye);

	18 void setFieldOfView(optional VRFieldOfView leftFov, optional VRFieldOfView r ightFov);

	19 DOMRect getRecommendedEyeRenderRect(VREye whichEye);

	20 };

OLD	NEW