Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 848043002: [Chromoting] Disable warning for unused strings in resources. (Closed)

Created:
5 years, 11 months ago by garykac
Modified:
5 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Disable warning for unused strings in resources. With the additional targets in Chromoting (Android, iOS and AppRemoting), the check to verify that each string is being used produces lots of noise because it is difficult to identify which strings should be used in each target. It is non-trivial to handle all these cases cleanly with our current approach so we'll need to disable these checks and re-visit how we want to handle them. BUG=448175 Committed: https://crrev.com/b7e9e03aefb4b14071acef9028cecafb5a4db35f Cr-Commit-Position: refs/heads/master@{#311574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M remoting/tools/verify_resources.py View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 11 months ago (2015-01-13 17:43:28 UTC) #2
Jamie
lgtm
5 years, 11 months ago (2015-01-14 19:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848043002/1
5 years, 11 months ago (2015-01-14 22:47:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 23:52:29 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:53:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e9e03aefb4b14071acef9028cecafb5a4db35f
Cr-Commit-Position: refs/heads/master@{#311574}

Powered by Google App Engine
This is Rietveld 408576698