Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 848033005: Use a window to catch WM_ENDSESSION. (Closed)

Created:
5 years, 11 months ago by Sigurður Ásgeirsson
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@sessionending_window
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a window to catch WM_ENDSESSION. Rejig the watcher to run a message loop on the main thread, and to do the blocking wait on a dedicated background thread. BUG=412384 Committed: https://crrev.com/e4462c0e439c489ad057060ba014d8899398c117 Cr-Commit-Position: refs/heads/master@{#311390}

Patch Set 1 #

Patch Set 2 : Move method definitions out of class, add some comments. #

Total comments: 5

Patch Set 3 : Address Erik's comments. #

Patch Set 4 : Merge to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -59 lines) Patch
M chrome/chrome_watcher/chrome_watcher_main.cc View 1 2 3 4 chunks +138 lines, -59 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sigurður Ásgeirsson
PTAL - this depends on CL 843113002.
5 years, 11 months ago (2015-01-13 20:46:55 UTC) #2
erikwright (departed)
LGTM with nits https://codereview.chromium.org/848033005/diff/20001/chrome/chrome_watcher/chrome_watcher_main.cc File chrome/chrome_watcher/chrome_watcher_main.cc (right): https://codereview.chromium.org/848033005/diff/20001/chrome/chrome_watcher/chrome_watcher_main.cc#newcode44 chrome/chrome_watcher/chrome_watcher_main.cc:44: private: blank line before https://codereview.chromium.org/848033005/diff/20001/chrome/chrome_watcher/chrome_watcher_main.cc#newcode54 chrome/chrome_watcher/chrome_watcher_main.cc:54: ...
5 years, 11 months ago (2015-01-13 21:24:04 UTC) #3
Sigurður Ásgeirsson
Thanks, committing.
5 years, 11 months ago (2015-01-14 00:46:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/848033005/60001
5 years, 11 months ago (2015-01-14 00:47:23 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-14 01:49:51 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 01:50:49 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e4462c0e439c489ad057060ba014d8899398c117
Cr-Commit-Position: refs/heads/master@{#311390}

Powered by Google App Engine
This is Rietveld 408576698