Store embed-script flag as metadata into snapshot blob.

src/snapshot-external.cc

Index: src/snapshot-external.cc
diff --git a/src/snapshot-external.cc b/src/snapshot-external.cc
index 2fda57125220085a12ff0bf78224ab5d7ff72ec5..8f1107cb9ff3c1ad5d3832bff838cb113272b2ac 100644
--- a/src/snapshot-external.cc
+++ b/src/snapshot-external.cc
@@ -26,9 +26,7 @@ void SetSnapshotFromFile(StartupData* snapshot_blob) {
   DCHECK(snapshot_blob->data);
   DCHECK(snapshot_blob->raw_size > 0);
   DCHECK(!external_startup_blob.data);
-  // Validate snapshot blob.
-  DCHECK(!Snapshot::ExtractStartupData(snapshot_blob).is_empty());
-  DCHECK(!Snapshot::ExtractContextData(snapshot_blob).is_empty());
+  DCHECK(Snapshot::SnapshotIsValid());

[vogelheim, 2015/01/13 14:45:32]

This looks buggy, or maybe I'm just not getting it:

Previously, this would check the parameter, before copying the parameter to
external_startup_snapshot static member. Now, it checks the the
external_startup_snapshot member, before copying. 

Assuming normal use, this would validate that whatever data was there before the
snapshot was set was valid?

   external_startup_blob = *snapshot_blob;
 }