Store embed-script flag as metadata into snapshot blob.

Store embed-script flag as metadata into snapshot blob.

R=vogelheim@chromium.org

Committed: https://crrev.com/b62f094884b95cf7b45484a27a9721a8477efc91
Cr-Commit-Position: refs/heads/master@{#26049}

[vogelheim, 2015-01-13 14:45:32]

lgtm, provided the issue in snapshot-external.cc is handled.

https://codereview.chromium.org/848023002/diff/1/src/snapshot-external.cc
File src/snapshot-external.cc (right):

https://codereview.chromium.org/848023002/diff/1/src/snapshot-external.cc#new...
src/snapshot-external.cc:29: DCHECK(Snapshot::SnapshotIsValid());
This looks buggy, or maybe I'm just not getting it:

Previously, this would check the parameter, before copying the parameter to
external_startup_snapshot static member. Now, it checks the the
external_startup_snapshot member, before copying. 

Assuming normal use, this would validate that whatever data was there before the
snapshot was set was valid?

[Yang, 2015-01-14 10:38:11]

On 2015/01/13 14:45:32, vogelheim wrote:
> lgtm, provided the issue in snapshot-external.cc is handled.
> 
> https://codereview.chromium.org/848023002/diff/1/src/snapshot-external.cc
> File src/snapshot-external.cc (right):
> 
>
https://codereview.chromium.org/848023002/diff/1/src/snapshot-external.cc#new...
> src/snapshot-external.cc:29: DCHECK(Snapshot::SnapshotIsValid());
> This looks buggy, or maybe I'm just not getting it:
> 
> Previously, this would check the parameter, before copying the parameter to
> external_startup_snapshot static member. Now, it checks the the
> external_startup_snapshot member, before copying. 
> 
> Assuming normal use, this would validate that whatever data was there before
the
> snapshot was set was valid?


You are right. Fixed.

[Yang, 2015-01-14 10:38:34]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-01-14 10:39:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/848023002/20001

[commit-bot: I haz the power, 2015-01-14 11:06:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-14 11:07:00]

Patchset 2 (id:??) landed as
https://crrev.com/b62f094884b95cf7b45484a27a9721a8477efc91
Cr-Commit-Position: refs/heads/master@{#26049}