Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 848007: Flakiness dashboard: use startsWith rather than contains to match expectatio... (Closed)

Created:
10 years, 9 months ago by Julie Parent
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Flakiness dashboard: use startsWith rather than contains to match expectation to test name. Dashboard was incorrectly matching a line like BUGFOO LINUX : media = PASS FAIL TIMEOUT with any test with the substring 'media' in it, like "fast/repaint/intermediate-layout-position-clip.html". TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/tools/layout_tests/flakiness_dashboard.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Julie Parent
10 years, 9 months ago (2010-03-12 00:51:55 UTC) #1
ojan
10 years, 9 months ago (2010-03-12 00:55:45 UTC) #2
lols. whoops. lgtm.

On Thu, Mar 11, 2010 at 4:51 PM, <jparent@chromium.org> wrote:

> Reviewers: ojan,
>
> Description:
> Flakiness dashboard:  use startsWith rather than contains to match
> expectation
> to test name.
> Dashboard was incorrectly matching a line like BUGFOO LINUX : media = PASS
> FAIL
> TIMEOUT with any test with the substring 'media' in it, like
> "fast/repaint/intermediate-layout-position-clip.html".
>
> TEST=none
> BUT=none
>
>
>
> Please review this at http://codereview.chromium.org/848007
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/tools/layout_tests/flakiness_dashboard.html
>
>
> Index: webkit/tools/layout_tests/flakiness_dashboard.html
> ===================================================================
> --- webkit/tools/layout_tests/flakiness_dashboard.html  (revision 41363)
> +++ webkit/tools/layout_tests/flakiness_dashboard.html  (working copy)
> @@ -894,7 +894,7 @@
>         addTestToAllExpectations(path, expectations);
>       } else {
>         for (var test in allTests) {
> -          if (stringContains(test, path)) {
> +          if (startsWith(test, path)) {
>             pathMatchesAnyTest = true;
>             addTestToAllExpectations(test, expectations);
>           }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698