Chromium Code Reviews
Help | Chromium Project | Sign in
(104)

Issue 848006: Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, ncarter, idana, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org, timsteele
Visibility:
Public.

Description

Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog).

This makes it possible to associate a single NetLog with a URLRequestContext, and then attach observers to that log to watch the stream of events.

This changelist attempts to do the most direct translation, so there will be subsequent iterations to clean up.

The user-visible behavior should remain unchanged.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41689

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 49

Patch Set 5 : Add back truncation behavior, and unbounded testing, to more directly match current behavior #

Patch Set 6 : Rename NetLog::SourceID --> NetLog::Source, and address nits #

Patch Set 7 : Use one NetLog for all contexts; also make late binding socket logs streamable rather than buffer #

Total comments: 18

Patch Set 8 : sync #

Patch Set 9 : Address willchan's comments #

Total comments: 16

Patch Set 10 : Split up RequestTracker into ConnectJobTracker+RequestTracker+RequestTrackerBase, address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2203 lines, -3442 lines) Lint Patch
M chrome/browser/io_thread.h View 9 2 chunks +2 lines, -0 lines 0 comments ? errors Download
M chrome/browser/io_thread.cc View 3 chunks +7 lines, -0 lines 0 comments ? errors Download
A chrome/browser/net/chrome_net_log.h View 1 2 3 4 5 6 7 8 1 chunk +54 lines, -0 lines 0 comments ? errors Download
A chrome/browser/net/chrome_net_log.cc View 1 2 3 4 5 6 7 8 9 1 chunk +53 lines, -0 lines 0 comments ? errors Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 4 5 6 7 6 chunks +4 lines, -9 lines 0 comments ? errors Download
M chrome/browser/net/dns_master.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments ? errors Download
A chrome/browser/net/passive_log_collector.h View 9 1 chunk +138 lines, -0 lines 0 comments ? errors Download
A + chrome/browser/net/passive_log_collector.cc View 9 1 chunk +268 lines, -142 lines 0 comments ? errors Download
A + chrome/browser/net/passive_log_collector_unittest.cc View 9 5 chunks +94 lines, -147 lines 0 comments ? errors Download
M chrome/browser/net/view_net_internals_job_factory.cc View 1 2 3 4 5 6 7 8 15 chunks +59 lines, -42 lines 0 comments ? errors Download
M chrome/browser/sync/notifier/communicator/ssl_socket_adapter.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M chrome/browser/sync/notifier/communicator/ssl_socket_adapter.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments ? errors Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments ? errors Download
M net/base/host_resolver.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments ? errors Download
M net/base/host_resolver.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M net/base/host_resolver_impl.h View 1 2 3 4 5 6 7 4 chunks +7 lines, -6 lines 0 comments 0 errors Download
M net/base/host_resolver_impl.cc View 1 2 3 4 5 6 7 17 chunks +47 lines, -49 lines 0 comments ? errors Download
M net/base/host_resolver_impl_unittest.cc View 1 2 3 4 5 6 7 7 chunks +36 lines, -27 lines 0 comments ? errors Download
D net/base/load_log.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -196 lines 0 comments ? errors Download
D net/base/load_log.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -48 lines 0 comments ? errors Download
D net/base/load_log_event_type_list.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -243 lines 0 comments ? errors Download
D net/base/load_log_unittest.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -130 lines 0 comments ? errors Download
M net/base/load_log_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -185 lines 0 comments ? errors Download
D net/base/load_log_util.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -74 lines 0 comments ? errors Download
D net/base/load_log_util.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -234 lines 0 comments ? errors Download
D net/base/load_log_util_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -138 lines 0 comments ? errors Download
M net/base/mapped_host_resolver.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/base/mapped_host_resolver.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M net/base/mapped_host_resolver_unittest.cc View 1 2 3 4 5 6 7 7 chunks +9 lines, -8 lines 0 comments ? errors Download
M net/base/mock_host_resolver.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/base/mock_host_resolver.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments ? errors Download
A + net/base/net_log.h View 1 2 3 4 5 6 7 8 5 chunks +144 lines, -102 lines 0 comments ? errors Download
A + net/base/net_log.cc View 1 2 3 4 5 6 1 chunk +131 lines, -25 lines 0 comments ? errors Download
A + net/base/net_log_event_type_list.h View 1 2 3 4 5 6 7 3 chunks +16 lines, -1 line 0 comments ? errors Download
A + net/base/net_log_unittest.h View 1 6 7 8 4 chunks +40 lines, -38 lines 0 comments 1 errors Download
A + net/base/net_log_util.h View 1 2 3 4 2 chunks +11 lines, -10 lines 0 comments ? errors Download
A + net/base/net_log_util.cc View 1 2 3 4 8 chunks +32 lines, -29 lines 0 comments 0 errors Download
A + net/base/net_log_util_unittest.cc View 1 2 3 4 4 chunks +85 lines, -78 lines 0 comments ? errors Download
M net/ftp/ftp_network_transaction.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments ? errors Download
M net/ftp/ftp_network_transaction.cc View 1 2 3 4 5 6 7 5 chunks +6 lines, -6 lines 0 comments ? errors Download
M net/ftp/ftp_transaction.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M net/http/http_basic_stream.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M net/http/http_basic_stream.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments 0 errors Download
M net/http/http_cache_transaction.h View 1 2 3 4 5 6 7 4 chunks +5 lines, -3 lines 0 comments 0 errors Download
M net/http/http_cache_transaction.cc View 1 2 3 4 5 6 7 15 chunks +18 lines, -18 lines 0 comments 0 errors Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 6 7 7 chunks +44 lines, -42 lines 0 comments 0 errors Download
M net/http/http_network_layer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M net/http/http_network_transaction.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/http/http_network_transaction.cc View 1 2 3 4 5 6 7 10 chunks +26 lines, -40 lines 0 comments 0 errors Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 5 6 7 5 chunks +12 lines, -12 lines 0 comments 0 errors Download
M net/http/http_stream_parser.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/http/http_stream_parser.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -6 lines 0 comments 0 errors Download
M net/http/http_transaction.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/http/http_transaction_unittest.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/net.gyp View 1 2 3 4 5 6 7 5 chunks +7 lines, -10 lines 0 comments ? errors Download
M net/proxy/init_proxy_resolver.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/proxy/init_proxy_resolver.cc View 1 2 3 4 5 6 7 8 chunks +18 lines, -24 lines 0 comments 0 errors Download
M net/proxy/init_proxy_resolver_unittest.cc View 1 2 3 4 5 6 7 5 chunks +38 lines, -36 lines 0 comments 0 errors Download
M net/proxy/mock_proxy_resolver.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_js_bindings.cc View 1 2 3 4 5 6 7 4 chunks +7 lines, -5 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_js_bindings_unittest.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -3 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_mac.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver_mac.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver_v8.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver_v8.cc View 1 2 3 4 5 6 7 8 chunks +29 lines, -27 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 3 4 5 6 7 6 chunks +24 lines, -20 lines 0 comments 0 errors Download
M net/proxy/proxy_resolver_winhttp.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_resolver_winhttp.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/proxy_service.h View 1 2 3 4 5 6 7 10 chunks +14 lines, -14 lines 0 comments 0 errors Download
M net/proxy/proxy_service.cc View 1 2 3 4 5 6 7 26 chunks +51 lines, -50 lines 0 comments 0 errors Download
M net/proxy/proxy_service_unittest.cc View 1 2 3 4 5 6 7 6 chunks +31 lines, -26 lines 0 comments 0 errors Download
M net/proxy/single_threaded_proxy_resolver.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/proxy/single_threaded_proxy_resolver.cc View 1 2 3 4 5 6 7 8 9 9 chunks +18 lines, -27 lines 0 comments 0 errors Download
M net/proxy/single_threaded_proxy_resolver_unittest.cc View 1 2 3 4 5 6 7 9 chunks +30 lines, -26 lines 0 comments 0 errors Download
M net/socket/client_socket.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -2 lines 0 comments 0 errors Download
M net/socket/client_socket_handle.h View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments 0 errors Download
M net/socket/client_socket_pool.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M net/socket/client_socket_pool_base.h View 1 2 3 4 5 6 7 12 chunks +17 lines, -17 lines 0 comments 0 errors Download
M net/socket/client_socket_pool_base.cc View 1 2 3 4 5 6 7 19 chunks +42 lines, -49 lines 0 comments 0 errors Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 3 4 5 6 7 8 9 15 chunks +77 lines, -80 lines 0 comments 0 errors Download
M net/socket/socket_test_util.h View 1 2 3 4 5 6 7 4 chunks +6 lines, -4 lines 0 comments 0 errors Download
M net/socket/socket_test_util.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/socket/socks5_client_socket.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/socks5_client_socket.cc View 1 2 3 4 5 6 7 13 chunks +33 lines, -35 lines 0 comments 0 errors Download
M net/socket/socks5_client_socket_unittest.cc View 1 2 3 4 5 6 7 6 chunks +22 lines, -22 lines 0 comments 0 errors Download
M net/socket/socks_client_socket.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/socks_client_socket.cc View 1 2 3 4 5 6 7 7 chunks +11 lines, -11 lines 0 comments 0 errors Download
M net/socket/socks_client_socket_unittest.cc View 1 2 3 4 5 6 7 9 chunks +45 lines, -31 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_mac.cc View 1 2 3 4 5 6 7 8 9 4 chunks +10 lines, -10 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_nss.cc View 1 2 3 4 5 6 7 6 chunks +8 lines, -8 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 4 5 6 7 7 chunks +17 lines, -17 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_win.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/ssl_client_socket_win.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -8 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_libevent.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_libevent.cc View 1 2 3 4 5 6 7 4 chunks +12 lines, -12 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_pool.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_pool.cc View 1 2 3 4 5 6 7 6 chunks +13 lines, -15 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_pool_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_unittest.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -7 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_win.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -3 lines 0 comments 0 errors Download
M net/socket/tcp_client_socket_win.cc View 1 2 3 4 5 6 7 4 chunks +14 lines, -14 lines 0 comments 0 errors Download
M net/socket_stream/socket_stream.h View 1 2 3 4 5 6 7 6 chunks +3 lines, -10 lines 0 comments ? errors Download
M net/socket_stream/socket_stream.cc View 1 2 3 4 5 6 7 14 chunks +21 lines, -28 lines 0 comments ? errors Download
M net/socket_stream/socket_stream_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -8 lines 0 comments ? errors Download
M net/spdy/spdy_network_transaction.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments 0 errors Download
M net/spdy/spdy_network_transaction.cc View 1 2 3 4 5 6 7 4 chunks +12 lines, -20 lines 0 comments 0 errors Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 3 4 5 6 7 5 chunks +30 lines, -30 lines 0 comments 0 errors Download
M net/spdy/spdy_session.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/spdy/spdy_session.cc View 1 2 3 4 5 6 7 7 chunks +7 lines, -7 lines 0 comments 0 errors Download
M net/spdy/spdy_stream.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M net/spdy/spdy_stream.cc View 1 2 3 4 5 6 7 4 chunks +10 lines, -18 lines 0 comments 0 errors Download
D net/url_request/request_tracker.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -192 lines 0 comments ? errors Download
D net/url_request/request_tracker_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -266 lines 0 comments ? errors Download
M net/url_request/url_request.h View 1 2 3 4 5 6 7 8 9 5 chunks +3 lines, -11 lines 0 comments ? errors Download
M net/url_request/url_request.cc View 1 2 3 4 5 6 7 7 chunks +15 lines, -24 lines 0 comments ? errors Download
M net/url_request/url_request_context.h View 1 2 3 4 5 6 7 5 chunks +8 lines, -18 lines 0 comments ? errors Download
M net/url_request/url_request_http_job.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/url_request/url_request_new_ftp_job.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments ? errors Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -12 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 8
eroman
4 years, 1 month ago #1
willchan
General comments. Some of them are half-baked. It was a lot of stuff to fit ...
4 years, 1 month ago #2
eroman
Thanks for getting started on this! Some responses to the big questions. http://codereview.chromium.org/848006/diff/58002/59113 File chrome/browser/net/chrome_net_log.h ...
4 years, 1 month ago #3
eroman
I also changed the client_socket_pool_base mechanism for logging (so it sends it directly to the ...
4 years, 1 month ago #4
willchan
I'm going to sleep soon because I'm too tired to think properly, but I'm stuck ...
4 years, 1 month ago #5
eroman
http://codereview.chromium.org/848006/diff/58002/59106 File net/base/net_log_unittest.h (right): http://codereview.chromium.org/848006/diff/58002/59106#newcode10 net/base/net_log_unittest.h:10: #include "net/base/net_log.h" On 2010/03/15 06:29:50, willchan wrote: > On ...
4 years, 1 month ago #6
willchan
LGTM I've run out of steam, but the design looks good and I added comments ...
4 years, 1 month ago #7
eroman
4 years, 1 month ago #8
I made the RequestTracker split change we discussed.

http://codereview.chromium.org/848006/diff/58002/59100
File net/base/net_log.h (right):

http://codereview.chromium.org/848006/diff/58002/59100#newcode160
net/base/net_log.h:160: void AddEvent(NetLog::EventType event_type) const;
On 2010/03/16 01:46:25, willchan wrote:
> On 2010/03/13 00:38:05, eroman wrote:
> > On 2010/03/12 23:52:35, willchan wrote:
> > > In situations like this, I usually think that you should inline the
> > definitions
> > > to make it obvious that they're just simple wrappers. 
> > 
> > Sure I can do that.
> > Actually, I originally had it that way but found it made the header less
> > readable because of many lines of pollution.
> > 
> > > Also, I don't think they should be const.
> > > BoundNetLog is conceptually basically the same thing as
> > > NetLog, it just binds the SourceID.  If that's the case, then why is the
> > > AddEvent() member function (conceptually a mutating function) non-const? 
I
> > know
> > > C++ lets you get away with this, but I think we should keep these as
> non-const
> > > member functions.
> > 
> > Heh, I knew this would come up :)
> > 
> > Basically the issue is how to pass around BoundNetLog into all of the
> consumers.
> > The cleanest way IMO was to have callers take a |const BoundNetLog& log|
> > parameter, which they could then use to initialize their own BoundNetLog
> member
> > variable. However, there were also a lot of callsites which wanted to log
> > directly into their function argument... having the log methods be non-const
> > meant needing to make a temporary copy of the parameter, give it a new name,
> and
> > then call the method that "writes" into it. This quickly lead to widespread
> > uglification, and seemed very artificial since effectively we are still
> logging
> > into that destination. So I decided to avoid the problem by making all the
> > methods const as well so they could be called directly. In this sense I
think
> of
> > BoundNetLog like a handle to a log; the handle always points to the same
thing
> > (immutable), but you can still do actions on its destination.
> > 
> > I considered some other alternatives:
> > 
> > (1) Make the function arguments |BoundNetLog& log|. This goes against google
> > style, and is wonky.
> > 
> > (2) Make the function arguments |BoundNetLog log|. This means each caller
gets
> a
> > copy. This is workable, but not desirable from a performance standpoint
since
> we
> > are doing extra AddRef/Release (on threadsaferefcounted) for no good reason.
> > 
> > (3) Make the function arguments |BoundNetLog* log|. I don't like this
approach
> > because it means callers can pass in NULL, and I don't want to handle NULLs
> (in
> > fact I am trying to get rid of all the NULLs). It also means callers can
> mutate
> > the log itself (replace it with something else) which really isn't something
I
> > want to be part of the API.
> 
> I think I prefer (3) here.  I'd document this by using DCHECK(log).  I'm fine
if
> you want to use this as a refactoring tool, but I don't think we should use
> const just so we can use a const reference to show that it can't be NULL.  I
> think assertions are the way to go.  We have plenty of other code that assumes
> some pointers are never NULL.
> 
> > 
> > 
> > If you want me to change these, please allow me to leave the const in as a
> > refactor tool, since the other styles don't lend themselves well to
automatic
> > search/replace.
> 
> 

Ok, I will work on this post-commit.

http://codereview.chromium.org/848006/diff/189001/190124
File chrome/browser/io_thread.h (right):

http://codereview.chromium.org/848006/diff/189001/190124#newcode18
chrome/browser/io_thread.h:18: class ChromeNetLog;
On 2010/03/16 01:46:25, willchan wrote:
> OCD, but perhaps sort ChromeNetLog alphabetically with Listvalue.

Done.

http://codereview.chromium.org/848006/diff/189001/190115
File chrome/browser/net/chrome_net_log.cc (right):

http://codereview.chromium.org/848006/diff/189001/190115#newcode14
chrome/browser/net/chrome_net_log.cc:14: 
On 2010/03/16 01:46:25, willchan wrote:
> extra newline

Done.

http://codereview.chromium.org/848006/diff/189001/190103
File net/base/load_log_unittest.cc (right):

http://codereview.chromium.org/848006/diff/189001/190103#newcode2
net/base/load_log_unittest.cc:2: // Use of this source code is governed by a
BSD-style license that can be
On 2010/03/16 01:46:25, willchan wrote:
> Can't we delete this file?

Oops, thought I had svn deleted it already!
Done.

http://codereview.chromium.org/848006/diff/189001/190023
File net/proxy/single_threaded_proxy_resolver.cc (right):

http://codereview.chromium.org/848006/diff/189001/190023#newcode324
net/proxy/single_threaded_proxy_resolver.cc:324:
job->net_log()->EndEvent(NetLog::TYPE_WAITING_FOR_SINGLE_PROXY_RESOLVER_THREAD);
On 2010/03/16 01:46:25, willchan wrote:
> 80 columns

Done.

http://codereview.chromium.org/848006/diff/189001/190064
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/848006/diff/189001/190064#newcode18
net/socket/ssl_client_socket_mac.cc:18: #include "net/base/net_log.h"
On 2010/03/16 01:46:25, willchan wrote:
> alphabetical

Done.

http://codereview.chromium.org/848006/diff/189001/190078
File net/url_request/url_request.h (right):

http://codereview.chromium.org/848006/diff/189001/190078#newcode512
net/url_request/url_request.h:512: const net::BoundNetLog& net_log() { return
net_log_; }
On 2010/03/16 01:46:25, willchan wrote:
> The accessor can be const, right?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434