Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: net/ftp/ftp_network_transaction.cc

Issue 848006: Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Split up RequestTracker into ConnectJobTracker+RequestTracker+RequestTrackerBase, address comments Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_network_transaction.h ('k') | net/ftp/ftp_transaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_network_transaction.cc
===================================================================
--- net/ftp/ftp_network_transaction.cc (revision 41560)
+++ net/ftp/ftp_network_transaction.cc (working copy)
@@ -10,8 +10,8 @@
#include "base/utf_string_conversions.h"
#include "net/base/connection_type_histograms.h"
#include "net/base/escape.h"
-#include "net/base/load_log.h"
#include "net/base/net_errors.h"
+#include "net/base/net_log.h"
#include "net/base/net_util.h"
#include "net/ftp/ftp_network_session.h"
#include "net/ftp/ftp_request_info.h"
@@ -73,8 +73,8 @@
int FtpNetworkTransaction::Start(const FtpRequestInfo* request_info,
CompletionCallback* callback,
- LoadLog* load_log) {
- load_log_ = load_log;
+ const BoundNetLog& net_log) {
+ net_log_ = net_log;
request_ = request_info;
if (request_->url.has_username()) {
@@ -508,7 +508,7 @@
// RFC 2428, we have to turn off IPv6 in FTP. See http://crbug.com/32945.
info.set_address_family(ADDRESS_FAMILY_IPV4);
// No known referrer.
- return resolver_.Resolve(info, &addresses_, &io_callback_, load_log_);
+ return resolver_.Resolve(info, &addresses_, &io_callback_, net_log_);
}
int FtpNetworkTransaction::DoCtrlResolveHostComplete(int result) {
@@ -520,7 +520,7 @@
int FtpNetworkTransaction::DoCtrlConnect() {
next_state_ = STATE_CTRL_CONNECT_COMPLETE;
ctrl_socket_.reset(socket_factory_->CreateTCPClientSocket(addresses_));
- return ctrl_socket_->Connect(&io_callback_, load_log_);
+ return ctrl_socket_->Connect(&io_callback_, net_log_);
}
int FtpNetworkTransaction::DoCtrlConnectComplete(int result) {
@@ -1119,7 +1119,7 @@
return Stop(rv);
data_address.SetPort(data_connection_port_);
data_socket_.reset(socket_factory_->CreateTCPClientSocket(data_address));
- return data_socket_->Connect(&io_callback_, load_log_);
+ return data_socket_->Connect(&io_callback_, net_log_);
}
int FtpNetworkTransaction::DoDataConnectComplete(int result) {
« no previous file with comments | « net/ftp/ftp_network_transaction.h ('k') | net/ftp/ftp_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698