net/http/http_stream_parser.cc - Issue 848006: Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_parser.cc

Issue 848006: Generalize the net module's LoadLog facility from a passive container, to an event stream (NetLog). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Split up RequestTracker into ConnectJobTracker+RequestTracker+RequestTrackerBase, address comments Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_parser.cc

===================================================================

--- net/http/http_stream_parser.cc (revision 41560)

+++ net/http/http_stream_parser.cc (working copy)

@@ -15,7 +15,7 @@

HttpStreamParser::HttpStreamParser(ClientSocketHandle* connection,

GrowableIOBuffer* read_buffer,

- LoadLog* load_log)

+ const BoundNetLog& net_log)

: io_state_(STATE_NONE),

request_(NULL),

request_headers_(NULL),

@@ -30,7 +30,7 @@

user_read_buf_len_(0),

user_callback_(NULL),

connection_(connection),

- load_log_(load_log),

+ net_log_(net_log),

ALLOW_THIS_IN_INITIALIZER_LIST(

io_callback_(this, &HttpStreamParser::OnIOComplete)) {

DCHECK_EQ(0, read_buffer->offset());

@@ -148,14 +148,12 @@

break;

case STATE_READ_HEADERS:

TRACE_EVENT_BEGIN("http.read_headers", request_, request_->url.spec());

- LoadLog::BeginEvent(load_log_,

- LoadLog::TYPE_HTTP_STREAM_PARSER_READ_HEADERS);

+ net_log_.BeginEvent(NetLog::TYPE_HTTP_STREAM_PARSER_READ_HEADERS);

result = DoReadHeaders();

break;

case STATE_READ_HEADERS_COMPLETE:

result = DoReadHeadersComplete(result);

- LoadLog::EndEvent(load_log_,

- LoadLog::TYPE_HTTP_STREAM_PARSER_READ_HEADERS);

+ net_log_.EndEvent(NetLog::TYPE_HTTP_STREAM_PARSER_READ_HEADERS);

TRACE_EVENT_END("http.read_headers", request_, request_->url.spec());

break;

case STATE_BODY_PENDING:

« no previous file with comments | « net/http/http_stream_parser.h ('k') | net/http/http_transaction.h » ('j') | no next file with comments »