Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: dart/tests/compiler/dart2js/message_kind_helper.dart

Issue 848003002: Remove CompilerCancelledException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42861 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/compiler/dart2js/message_kind_helper.dart
diff --git a/dart/tests/compiler/dart2js/message_kind_helper.dart b/dart/tests/compiler/dart2js/message_kind_helper.dart
index 22589354f6a59aeab2d5ddd53f480c818971b4b7..0f98572fba3a21ea5ae5b513af948e4fc6e0b023 100644
--- a/dart/tests/compiler/dart2js/message_kind_helper.dart
+++ b/dart/tests/compiler/dart2js/message_kind_helper.dart
@@ -49,16 +49,6 @@ final Set<MessageKind> kindsWithPendingClasses = new Set<MessageKind>.from([
// If you add something here, please file a *new* bug report.
]);
-/// Most messages can be tested without causing a fatal error. Add an exception
-/// here if a fatal error is unavoidable.
-/// Try to avoid adding exceptions here; a fatal error causes the compiler to
-/// stop before analyzing all input, and it isn't safe to reuse it.
-final Set<MessageKind> kindsWithFatalErrors = new Set<MessageKind>.from([
- // If you add something here, please file a *new* bug report.
- MessageKind.UNMATCHED_TOKEN,
- MessageKind.UNTERMINATED_STRING,
-]);
-
Future<Compiler> check(MessageKind kind, Compiler cachedCompiler) {
Expect.isNotNull(kind.howToFix);
Expect.isFalse(kind.examples.isEmpty);
@@ -120,8 +110,6 @@ Future<Compiler> check(MessageKind kind, Compiler cachedCompiler) {
throw 'Unexpected messages found.';
}
}
- Expect.isTrue(!compiler.compilerWasCancelled ||
- kindsWithFatalErrors.contains(kind));
bool pendingStuff = false;
for (var e in compiler.resolver.pendingClassesToBePostProcessed) {
@@ -138,7 +126,7 @@ Future<Compiler> check(MessageKind kind, Compiler cachedCompiler) {
}
Expect.isTrue(!pendingStuff || kindsWithPendingClasses.contains(kind));
- if (!pendingStuff && !compiler.compilerWasCancelled) {
+ if (!pendingStuff) {
// If there is pending stuff, or the compiler was cancelled, we
// shouldn't reuse the compiler.
cachedCompiler = compiler;
« no previous file with comments | « dart/tests/compiler/dart2js/incremental/compile_all.dart ('k') | dart/tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698