Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 847913005: move HandleApiCall builtin to assembly (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 10 months ago
CC:
jochen (gone - plz use gerrit), v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

move HandleApiCall builtin to assembly BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : remove macro assembler change #

Patch Set 9 : remove trace extension change #

Patch Set 10 : cleanup, drop js object check #

Patch Set 11 : add test #

Patch Set 12 : fix throw #

Patch Set 13 : another test #

Patch Set 14 : more tests #

Patch Set 15 : remove tests #

Total comments: 1

Patch Set 16 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -8 lines) Patch
M src/builtins.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 2 chunks +22 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-api.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +164 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-21 12:01:39 UTC) #3
https://codereview.chromium.org/847913005/diff/300001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/847913005/diff/300001/src/x64/code-stubs-x64....
src/x64/code-stubs-x64.cc:5041: __ j(not_equal, &prototype_chain_loop_next,
Label::kNear);
I wonder whether we can here already jump to illegal_receiver?

Powered by Google App Engine
This is Rietveld 408576698