Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 847883002: Reland "Throttle resource message requests during user interaction" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pull out ThreadChecker fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/scheduler/null_renderer_scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 2044f81e8416a80ee225954365b56fe217c02a26..d96caefad435cf27a77fb2d2634862e4b9cbe8b9 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -105,6 +105,7 @@
#include "content/renderer/render_view_impl.h"
#include "content/renderer/renderer_blink_platform_impl.h"
#include "content/renderer/scheduler/renderer_scheduler.h"
+#include "content/renderer/scheduler/resource_dispatch_throttler.h"
#include "content/renderer/service_worker/embedded_worker_context_message_filter.h"
#include "content/renderer/service_worker/embedded_worker_dispatcher.h"
#include "content/renderer/shared_worker/embedded_shared_worker_stub.h"
@@ -196,6 +197,16 @@ namespace {
const int64 kInitialIdleHandlerDelayMs = 1000;
const int64 kLongIdleHandlerDelayMs = 30*1000;
+#if defined(OS_ANDROID)
+// On Android, resource messages can each take ~1.5ms to dispatch on the browser
+// IO thread. Limiting the message rate to 3/frame at 60hz ensures that the
+// induced work takes but a fraction (~1/4) of the overall frame budget.
+const int kMaxResourceRequestsPerFlushWhenThrottled = 3;
+#else
+const int kMaxResourceRequestsPerFlushWhenThrottled = 8;
+#endif
+const double kThrottledResourceRequestFlushPeriodS = 1. / 60.;
+
// Maximum allocation size allowed for image scaling filters that
// require pre-scaling. Skia will fallback to a filter that doesn't
// require pre-scaling if the default filter would require an
@@ -475,6 +486,14 @@ void RenderThreadImpl::Init() {
channel()->SetListenerTaskRunner(renderer_scheduler_->DefaultTaskRunner());
embedded_worker_dispatcher_.reset(new EmbeddedWorkerDispatcher());
+ // Note: This may reorder messages from the ResourceDispatcher with respect to
+ // other subsystems.
+ resource_dispatch_throttler_.reset(new ResourceDispatchThrottler(
+ static_cast<RenderThread*>(this), renderer_scheduler_.get(),
+ base::TimeDelta::FromSecondsD(kThrottledResourceRequestFlushPeriodS),
+ kMaxResourceRequestsPerFlushWhenThrottled));
+ resource_dispatcher()->set_message_sender(resource_dispatch_throttler_.get());
+
media_stream_center_ = NULL;
db_message_filter_ = new DBMessageFilter();
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/scheduler/null_renderer_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698