mojob.py: explicitly select CPU architecture.

mojob.py: explicitly select CPU architecture.

NaCl tests will need to know the target architecture, so explicitly select it
in mojob.py rather than letting GN select it implicitly.  Allow the
architecture to be overridden on the command line.

BUG=https://code.google.com/p/chromium/issues/detail?id=401761
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f93c0fa98da80e0c25f3e835af2a2d20e8e2c7aa

[Nick Bray (chromium), 2015-01-12 22:22:54]

ncbray@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-01-12 22:32:44]

Add a target_arch field to mopy/config.py.

[Nick Bray (chromium), 2015-01-12 23:08:41]

PTAL

[viettrungluu, 2015-01-12 23:26:41]

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py
File mojo/tools/mojob.py (right):

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py#newc...
mojo/tools/mojob.py:119: gn_args.append(r'''cpu_arch=\"%s\"''' %
config.target_arch)
nit: add blank line below

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py#newc...
mojo/tools/mojob.py:220: nacl_parser.add_argument('--nacl', help='Add in NaCl',
default=False,
These should just be added to parent_parser.

[Nick Bray (chromium), 2015-01-13 00:05:20]

PTAL

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py
File mojo/tools/mojob.py (right):

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py#newc...
mojo/tools/mojob.py:119: gn_args.append(r'''cpu_arch=\"%s\"''' %
config.target_arch)
On 2015/01/12 23:26:40, viettrungluu wrote:
> nit: add blank line below

Done.

https://codereview.chromium.org/847863004/diff/20001/mojo/tools/mojob.py#newc...
mojo/tools/mojob.py:220: nacl_parser.add_argument('--nacl', help='Add in NaCl',
default=False,
On 2015/01/12 23:26:40, viettrungluu wrote:
> These should just be added to parent_parser.

Done.

[viettrungluu, 2015-01-13 21:04:04]

LGTM w/nits

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.py
File mojo/tools/mopy/config.py (right):

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.p...
mojo/tools/mopy/config.py:82: if machine in ('x86', 'x86-32', 'x86_32', 'x8632',
'i386', 'i686', 'ia32',
nit: Apparently, in this file, we prefer to use " for all strings.

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.p...
mojo/tools/mopy/config.py:85: if machine in ('x86-64', 'amd64', 'x86_64',
'x8664', '64'):
" (etc.)

[Nick Bray (chromium), 2015-01-13 21:39:57]

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.py
File mojo/tools/mopy/config.py (right):

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.p...
mojo/tools/mopy/config.py:82: if machine in ('x86', 'x86-32', 'x86_32', 'x8632',
'i386', 'i686', 'ia32',
On 2015/01/13 21:04:04, viettrungluu wrote:
> nit: Apparently, in this file, we prefer to use " for all strings.

Done.

https://codereview.chromium.org/847863004/diff/40001/mojo/tools/mopy/config.p...
mojo/tools/mopy/config.py:85: if machine in ('x86-64', 'amd64', 'x86_64',
'x8664', '64'):
On 2015/01/13 21:04:04, viettrungluu wrote:
> " (etc.)

Done.

[Nick Bray (chromium), 2015-01-13 21:40:02]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2015-01-13 21:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 21:44:51]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Nick Bray (chromium), 2015-01-13 22:03:09]

Committed patchset #4 (id:60001) manually as
f93c0fa98da80e0c25f3e835af2a2d20e8e2c7aa (presubmit successful).