SkDiscardableMemory::Factory class

SkDiscardableMemory::Factory class

Implementation in SkImageCache which turns all SkImageCache subclasses
into DMFactorys.

Modify SkDiscardablePixelRef to use either a DMFactory or a the
default SkDiscardableMemory::Create() function.

Remove SkLazyPixelRef, since everything it can do can be done by
either SkCachingPixleRef or a SkDiscardablePixelRef.

Move LAZY_CACHE_STATS from SkLazyPixelRef to SkDiscardablePixelRef.

Move SkDiscardableMemory.h to include/core, since Chrome already is
relying on it.

SkBitmapFactory uses SkDiscardablePixelRef+DMFactory instead of
SkLazyPixelRef.

All tests which directly referenced SkLazyPixelRef no longer do that.

BUG=

[hal.canary, 2013-11-24 21:12:45]

244 insertions, 527 deletions

This is an alternative to 83663006 that removes SkLazyPixelRef instead of
modifying it.

[scroggo, 2013-12-02 19:00:08]

Can you add to the change description what the goal is?

https://codereview.chromium.org/84783002/diff/1/include/lazy/SkImageCache.h
File include/lazy/SkImageCache.h (right):

https://codereview.chromium.org/84783002/diff/1/include/lazy/SkImageCache.h#n...
include/lazy/SkImageCache.h:23: virtual SkDiscardableMemory* create(size_t
bytes) SK_OVERRIDE;
Need this be virtual? Can you imagine a different implementation for a subclass?

It also seems like it doesn't need to be on this class, since it only uses
public functions from this class.

Can you add comments?

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkBitmapFactory.cpp
File src/lazy/SkBitmapFactory.cpp (right):

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkBitmapFactory.cpp#...
src/lazy/SkBitmapFactory.cpp:101: // selector reutuns NULL, that is taken as an
instruction to use
returns*

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkDiscardablePixelRef.h
File src/lazy/SkDiscardablePixelRef.h (right):

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkDiscardablePixelRe...
src/lazy/SkDiscardablePixelRef.h:40: SkDiscardableMemory::Factory* factory =
NULL);
Can you add a comment explaining how the factory is used?

Please include in the comment whether Install calls ref().

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkImageCache.cpp
File src/lazy/SkImageCache.cpp (right):

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkImageCache.cpp#new...
src/lazy/SkImageCache.cpp:13: static SkDiscardableMemory * create(SkImageCache*
cache, size_t size);
SkDiscardableMemory* create

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkImageCache.cpp#new...
src/lazy/SkImageCache.cpp:25: SkDiscardableMemory *
ImageCacheBackedDM::create(SkImageCache* cache,
SkDiscardableMemory* ImageCacheBackedDM...

https://codereview.chromium.org/84783002/diff/1/src/lazy/SkImageCache.cpp#new...
src/lazy/SkImageCache.cpp:39: : fCache(cache), fId(id), fPtr(ptr) {
These should be on their own line:

: fCache(cache)
, fId(id)
, fPtr(ptr) {

The brace could go on the next line (the style guide has not been updated to
reflect that, but I think we're leaning towards changing it to place the brace
on the next line).

https://codereview.chromium.org/84783002/diff/1/tests/DrawBitmapRectTest.cpp
File tests/DrawBitmapRectTest.cpp (right):

https://codereview.chromium.org/84783002/diff/1/tests/DrawBitmapRectTest.cpp#...
tests/DrawBitmapRectTest.cpp:25: info->fColorType = kPMColor_SkColorType;
Is this a separate bug?