Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 847823002: CompleteParserRecorder: Don't do zero-sized allocations. (Closed)

Created:
5 years, 11 months ago by marja
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CompleteParserRecorder: Don't do zero-sized allocations. Instead, we should use Collector::kMinCapacity. R=jochen@chromium.org BUG=v8:3727 LOG=N Committed: https://crrev.com/665c6faad21edc4280678d99db6619f057753498 Cr-Commit-Position: refs/heads/master@{#26030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/preparse-data.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
marja
jochen, ptal
5 years, 11 months ago (2015-01-12 16:10:32 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-12 16:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847823002/1
5 years, 11 months ago (2015-01-12 17:04:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 17:31:54 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 17:32:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/665c6faad21edc4280678d99db6619f057753498
Cr-Commit-Position: refs/heads/master@{#26030}

Powered by Google App Engine
This is Rietveld 408576698