Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 847813002: Update typesetting features when letter-spacing is changed. (Closed)

Created:
5 years, 11 months ago by andersr
Modified:
5 years, 11 months ago
CC:
blink-reviews, krit, Rik, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update typesetting features when letter-spacing is changed. The typesetting features depend on letter-spacing, yet we don't call updateTypesettingFeatures when letter-spacing is set. This causes ligatures to incorrectly remain enabled for non-zero letter-spacing when font-variant- ligatures is used. R=dglazkov@chromium.org BUG=448048 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M LayoutTests/fast/text/font-ligature-letter-spacing.html View 2 chunks +19 lines, -6 lines 0 comments Download
M LayoutTests/fast/text/font-ligature-letter-spacing-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
andersr
5 years, 11 months ago (2015-01-12 15:45:51 UTC) #1
jbroman
lgtm
5 years, 11 months ago (2015-01-13 16:10:42 UTC) #3
jbroman
On 2015/01/13 16:10:42, jbroman wrote: > lgtm (but I'm not an OWNER, so you'll need ...
5 years, 11 months ago (2015-01-13 16:11:10 UTC) #4
Dominik Röttsches
LGTM, thanks!
5 years, 11 months ago (2015-01-13 16:27:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847813002/1
5 years, 11 months ago (2015-01-13 16:31:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/40641)
5 years, 11 months ago (2015-01-13 19:18:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847813002/1
5 years, 11 months ago (2015-01-13 21:24:41 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 22:39:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188331

Powered by Google App Engine
This is Rietveld 408576698