Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: Source/core/dom/PendingScript.h

Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add ScriptSourceCode::isNull() comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/PendingScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/PendingScript.h
diff --git a/Source/core/dom/PendingScript.h b/Source/core/dom/PendingScript.h
index dae1150524c1d77c5925514fc28b248ddd641ef3..4df094a392526ea9b5cf9f817baa7b274b9eb0a3 100644
--- a/Source/core/dom/PendingScript.h
+++ b/Source/core/dom/PendingScript.h
@@ -26,8 +26,6 @@
#ifndef PendingScript_h
#define PendingScript_h
-#include "core/dom/Element.h"
-#include "core/fetch/ResourceClient.h"
#include "core/fetch/ResourceOwner.h"
#include "core/fetch/ScriptResource.h"
#include "platform/heap/Handle.h"
@@ -37,6 +35,7 @@
namespace blink {
+class Element;
class ScriptSourceCode;
class ScriptStreamer;
@@ -68,7 +67,7 @@ public:
void stopWatchingForLoad(ScriptResourceClient*);
Element* element() const { return m_element.get(); }
- void setElement(Element* element) { m_element = element; }
+ void setElement(Element*);
PassRefPtrWillBeRawPtr<Element> releaseElementAndClear();
void setScriptResource(ScriptResource*);
@@ -80,7 +79,7 @@ public:
ScriptSourceCode getSource(const KURL& documentURL, bool& errorOccurred) const;
- void setStreamer(PassRefPtr<ScriptStreamer>);
+ void setStreamer(PassRefPtrWillBeRawPtr<ScriptStreamer>);
bool isReady() const;
@@ -89,7 +88,7 @@ private:
RefPtrWillBeMember<Element> m_element;
TextPosition m_startingPosition; // Only used for inline script tags.
- RefPtr<ScriptStreamer> m_streamer;
+ RefPtrWillBeMember<ScriptStreamer> m_streamer;
};
} // namespace blink
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/PendingScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698