Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add ScriptSourceCode::isNull() comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptDebugServer.h
diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h
index 9fb54dd12d075a39882af8b6c715421108693df1..a99033c7f87569a8c07bf2a7f3fa677606332925 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.h
+++ b/Source/bindings/core/v8/ScriptDebugServer.h
@@ -48,9 +48,12 @@ class ScriptSourceCode;
class ScriptValue;
class JavaScriptCallFrame;
-class ScriptDebugServer {
+class ScriptDebugServer : public NoBaseWillBeGarbageCollectedFinalized<ScriptDebugServer> {
WTF_MAKE_NONCOPYABLE(ScriptDebugServer);
public:
+ virtual ~ScriptDebugServer();
+ virtual void trace(Visitor*);
+
String setBreakpoint(const String& sourceID, const ScriptBreakpoint&, int* actualLineNumber, int* actualColumnNumber, bool interstatementLocation);
void removeBreakpoint(const String& breakpointId);
void clearBreakpoints();
@@ -104,7 +107,7 @@ public:
virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace);
virtual void setPreprocessorSource(const String&) { }
virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) { }
- virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&);
+ virtual ScriptSourceCode preprocess(LocalFrame*, const ScriptSourceCode&);
virtual String preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName);
virtual void clearPreprocessor() { }
@@ -115,7 +118,6 @@ public:
protected:
explicit ScriptDebugServer(v8::Isolate*);
- virtual ~ScriptDebugServer();
virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Context>) = 0;
virtual void runMessageLoopOnPause(v8::Handle<v8::Context>) = 0;
« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698