Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: nullptr tidying Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.h
diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h
index 61a35127e8567dbe2f1d60ccff68436494fd0295..5dc5ec752c0d020b8ee00e4ead3e8b8b064219ea 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.h
+++ b/Source/bindings/core/v8/ScriptDebugServer.h
@@ -31,6 +31,7 @@
#ifndef ScriptDebugServer_h
#define ScriptDebugServer_h
+#include "bindings/core/v8/Nullable.h"
#include "bindings/core/v8/ScopedPersistent.h"
#include "core/inspector/ScriptBreakpoint.h"
#include "core/inspector/ScriptCallStack.h"
@@ -48,9 +49,12 @@ class ScriptSourceCode;
class ScriptValue;
class JavaScriptCallFrame;
-class ScriptDebugServer {
+class ScriptDebugServer : public NoBaseWillBeGarbageCollectedFinalized<ScriptDebugServer> {
WTF_MAKE_NONCOPYABLE(ScriptDebugServer);
public:
+ virtual ~ScriptDebugServer();
+ virtual void trace(Visitor*);
+
String setBreakpoint(const String& sourceID, const ScriptBreakpoint&, int* actualLineNumber, int* actualColumnNumber, bool interstatementLocation);
void removeBreakpoint(const String& breakpointId);
void clearBreakpoints();
@@ -104,7 +108,7 @@ public:
virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionDetailsText, int* lineNumber, int* columnNumber, RefPtrWillBeRawPtr<ScriptCallStack>* stackTrace);
virtual void setPreprocessorSource(const String&) { }
virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) { }
- virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&);
+ virtual Nullable<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&);
virtual String preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName);
virtual void clearPreprocessor() { }
@@ -113,7 +117,6 @@ public:
protected:
explicit ScriptDebugServer(v8::Isolate*);
- virtual ~ScriptDebugServer();
virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Context>) = 0;
virtual void runMessageLoopOnPause(v8::Handle<v8::Context>) = 0;

Powered by Google App Engine
This is Rietveld 408576698