Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 847803002: Make ScriptStreamer and dependents Oilpan friendly. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add ScriptSourceCode::isNull() comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 , m_breakpointsActivated(true) 79 , m_breakpointsActivated(true)
80 , m_isolate(isolate) 80 , m_isolate(isolate)
81 , m_runningNestedMessageLoop(false) 81 , m_runningNestedMessageLoop(false)
82 { 82 {
83 } 83 }
84 84
85 ScriptDebugServer::~ScriptDebugServer() 85 ScriptDebugServer::~ScriptDebugServer()
86 { 86 {
87 } 87 }
88 88
89 void ScriptDebugServer::trace(Visitor* visitor)
90 {
91 }
92
89 String ScriptDebugServer::setBreakpoint(const String& sourceID, const ScriptBrea kpoint& scriptBreakpoint, int* actualLineNumber, int* actualColumnNumber, bool i nterstatementLocation) 93 String ScriptDebugServer::setBreakpoint(const String& sourceID, const ScriptBrea kpoint& scriptBreakpoint, int* actualLineNumber, int* actualColumnNumber, bool i nterstatementLocation)
90 { 94 {
91 v8::HandleScope scope(m_isolate); 95 v8::HandleScope scope(m_isolate);
92 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext(); 96 v8::Local<v8::Context> debuggerContext = v8::Debug::GetDebugContext();
93 v8::Context::Scope contextScope(debuggerContext); 97 v8::Context::Scope contextScope(debuggerContext);
94 98
95 v8::Local<v8::Object> info = v8::Object::New(m_isolate); 99 v8::Local<v8::Object> info = v8::Object::New(m_isolate);
96 info->Set(v8AtomicString(m_isolate, "sourceID"), v8String(debuggerContext->G etIsolate(), sourceID)); 100 info->Set(v8AtomicString(m_isolate, "sourceID"), v8String(debuggerContext->G etIsolate(), sourceID));
97 info->Set(v8AtomicString(m_isolate, "lineNumber"), v8::Integer::New(debugger Context->GetIsolate(), scriptBreakpoint.lineNumber)); 101 info->Set(v8AtomicString(m_isolate, "lineNumber"), v8::Integer::New(debugger Context->GetIsolate(), scriptBreakpoint.lineNumber));
98 info->Set(v8AtomicString(m_isolate, "columnNumber"), v8::Integer::New(debugg erContext->GetIsolate(), scriptBreakpoint.columnNumber)); 102 info->Set(v8AtomicString(m_isolate, "columnNumber"), v8::Integer::New(debugg erContext->GetIsolate(), scriptBreakpoint.columnNumber));
(...skipping 637 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 *columnNumber = message->GetStartColumn(); 740 *columnNumber = message->GetStartColumn();
737 v8::Handle<v8::StackTrace> messageStackTrace = message->GetStackTrac e(); 741 v8::Handle<v8::StackTrace> messageStackTrace = message->GetStackTrac e();
738 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount () > 0) 742 if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount () > 0)
739 *stackTrace = createScriptCallStack(m_isolate, messageStackTrace , messageStackTrace->GetFrameCount()); 743 *stackTrace = createScriptCallStack(m_isolate, messageStackTrace , messageStackTrace->GetFrameCount());
740 } 744 }
741 } else { 745 } else {
742 *result = ScriptValue(scriptState, value); 746 *result = ScriptValue(scriptState, value);
743 } 747 }
744 } 748 }
745 749
746 PassOwnPtr<ScriptSourceCode> ScriptDebugServer::preprocess(LocalFrame*, const Sc riptSourceCode&) 750 ScriptSourceCode ScriptDebugServer::preprocess(LocalFrame*, const ScriptSourceCo de&)
747 { 751 {
748 return PassOwnPtr<ScriptSourceCode>(); 752 return ScriptSourceCode();
749 } 753 }
750 754
751 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName) 755 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName)
752 { 756 {
753 return source; 757 return source;
754 } 758 }
755 759
756 } // namespace blink 760 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.h ('k') | Source/bindings/core/v8/ScriptPreprocessor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698