Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 847723003: Revert of Linux Sandbox: move init processes to new session id. (Closed)

Created:
5 years, 11 months ago by jln (very slow on Chromium)
Modified:
5 years, 11 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln+watch_chromium.org, rickyz (no longer on Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux Sandbox: move init processes to new session id. (patchset #1 id:1 of https://codereview.chromium.org/837083002/) Reason for revert: Preemptively revert in case it caused a performance regression described in https://crbug.com/447164 even though it seems unlikely. Original issue's description: > Linux Sandbox: move init processes to new session id. > > The setuid sandbox creates new PID namespaces. Make sure to have > the new init processes be inside a new session id and process group > so that children can't signal processes outside of the PID namespace. > > BUG=446680 > > Committed: https://crrev.com/f48cead580e6c82a8f3c4ac2a493249da780ee28 > Cr-Commit-Position: refs/heads/master@{#310394} TBR=mdempsky@chromium.org NOTREECHECKS=true NOTRY=true BUG=446680, 447164 Committed: https://crrev.com/419f5a54506d5b50730e9be432f9363ed1b62f07 Cr-Commit-Position: refs/heads/master@{#311098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M components/nacl/loader/sandbox_linux/nacl_sandbox_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client.h View 2 chunks +1 line, -7 lines 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
Created Revert of Linux Sandbox: move init processes to new session id.
5 years, 11 months ago (2015-01-12 20:14:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847723003/1
5 years, 11 months ago (2015-01-12 20:15:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 20:18:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/419f5a54506d5b50730e9be432f9363ed1b62f07 Cr-Commit-Position: refs/heads/master@{#311098}
5 years, 11 months ago (2015-01-12 20:20:15 UTC) #4
mdempsky
5 years, 11 months ago (2015-01-12 20:22:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698