Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 8477019: Adds Window::MoveChildToFront, with surrounding changes. (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, tfarina, Paweł Hajdan Jr., piman+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Adds Window::MoveChildToFront, with surrounding changes. BUG=102580 102578 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109032

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -178 lines) Patch
M chrome/browser/chromeos/native_dialog_window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +30 lines, -12 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M ui/gfx/compositor/layer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/compositor/layer.cc View 1 1 chunk +21 lines, -6 lines 0 comments Download
M ui/gfx/rect.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M views/widget/native_widget_aura.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_aura.cc View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M views/widget/native_widget_gtk.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M views/widget/native_widget_private.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_views.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_views.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M views/widget/native_widget_wayland.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_wayland.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M views/widget/native_widget_win.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_win.cc View 1 2 4 chunks +0 lines, -101 lines 0 comments Download
M views/widget/widget.h View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M views/widget/widget.cc View 1 2 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years, 1 month ago (2011-11-04 23:25:38 UTC) #1
Ben Goodger (Google)
lgtm
9 years, 1 month ago (2011-11-07 16:54:06 UTC) #2
sky
My first patch didn't compile as it was trying to use EnsureRectIsVisibleInRect, which was only ...
9 years, 1 month ago (2011-11-07 21:41:04 UTC) #3
Ben Goodger (Google)
9 years, 1 month ago (2011-11-07 21:45:17 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698