Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: sky/engine/core/editing/FrameSelection.cpp

Issue 847633002: Remove dead boolean argument (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/editing/FrameSelection.h ('k') | sky/engine/core/rendering/RenderView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/editing/FrameSelection.cpp
diff --git a/sky/engine/core/editing/FrameSelection.cpp b/sky/engine/core/editing/FrameSelection.cpp
index dfd96aafb6142599bb104d0598e718240ea6600e..b3964dd955e0d8c237d91faf2242f1f737778b99 100644
--- a/sky/engine/core/editing/FrameSelection.cpp
+++ b/sky/engine/core/editing/FrameSelection.cpp
@@ -1527,7 +1527,7 @@ String FrameSelection::selectedText() const
return plainText(toNormalizedRange().get()).replace(0, "");
}
-FloatRect FrameSelection::bounds(bool clipToVisibleContent) const
+FloatRect FrameSelection::bounds() const
{
m_frame->document()->updateRenderTreeIfNeeded();
@@ -1537,8 +1537,7 @@ FloatRect FrameSelection::bounds(bool clipToVisibleContent) const
if (!view || !renderView)
return FloatRect();
- LayoutRect selectionRect = renderView->selectionBounds(clipToVisibleContent);
- return clipToVisibleContent ? intersection(selectionRect, view->visibleContentRect()) : selectionRect;
+ return renderView->selectionBounds();
}
void FrameSelection::revealSelection(const ScrollAlignment& alignment, RevealExtentOption revealExtentOption)
@@ -1552,7 +1551,7 @@ void FrameSelection::revealSelection(const ScrollAlignment& alignment, RevealExt
rect = absoluteCaretBounds();
break;
case RangeSelection:
- rect = revealExtentOption == RevealExtent ? VisiblePosition(extent()).absoluteCaretBounds() : enclosingIntRect(bounds(false));
+ rect = revealExtentOption == RevealExtent ? VisiblePosition(extent()).absoluteCaretBounds() : enclosingIntRect(bounds());
break;
}
« no previous file with comments | « sky/engine/core/editing/FrameSelection.h ('k') | sky/engine/core/rendering/RenderView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698