Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 847633002: Remove dead boolean argument (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M sky/engine/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
5 years, 11 months ago (2015-01-10 04:04:53 UTC) #2
esprehn
lgtm, bools suck,
5 years, 11 months ago (2015-01-10 04:05:10 UTC) #3
ojan
5 years, 11 months ago (2015-01-10 04:08:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00d10ec484e27964b0b98e328a5fd76e656902a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698