Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: tools/run-bisect-perf-regression.py

Issue 847603002: Replace builder_host and builder_port with builder_type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update sample configs for win and mac. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/auto_bisect/request_build.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Performance Test Bisect Tool 6 """Run Performance Test Bisect Tool
7 7
8 This script is used by a try bot to run the bisect script with the parameters 8 This script is used by a try bot to run the bisect script with the parameters
9 specified in the bisect config file. It checks out a copy of the depot in 9 specified in the bisect config file. It checks out a copy of the depot in
10 a subdirectory 'bisect' of the working directory provided, annd runs the 10 a subdirectory 'bisect' of the working directory provided, annd runs the
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 ] 504 ]
505 505
506 # Add flags for any optional config parameters if given in the config. 506 # Add flags for any optional config parameters if given in the config.
507 options = [ 507 options = [
508 ('repeat_count', '--repeat_test_count'), 508 ('repeat_count', '--repeat_test_count'),
509 ('truncate_percent', '--truncate_percent'), 509 ('truncate_percent', '--truncate_percent'),
510 ('max_time_minutes', '--max_time_minutes'), 510 ('max_time_minutes', '--max_time_minutes'),
511 ('bisect_mode', '--bisect_mode'), 511 ('bisect_mode', '--bisect_mode'),
512 ('improvement_direction', '--improvement_direction'), 512 ('improvement_direction', '--improvement_direction'),
513 ('bug_id', '--bug_id'), 513 ('bug_id', '--bug_id'),
514 ('builder_host', '--builder_host'), 514 ('builder_type', '--builder_type'),
515 ('builder_port', '--builder_port'),
516 ] 515 ]
517 for config_key, flag in options: 516 for config_key, flag in options:
518 if config.has_key(config_key): 517 if config.has_key(config_key):
519 cmd.extend([flag, config[config_key]]) 518 cmd.extend([flag, config[config_key]])
520 519
521 cmd.extend(['--build_preference', 'ninja']) 520 cmd.extend(['--build_preference', 'ninja'])
522 521
523 # Possibly set the target platform name based on the browser name in a 522 # Possibly set the target platform name based on the browser name in a
524 # Telemetry command. 523 # Telemetry command.
525 if 'android-chrome-shell' in config['command']: 524 if 'android-chrome-shell' in config['command']:
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 if config and config_is_valid: 653 if config and config_is_valid:
655 return _SetupAndRunPerformanceTest(config, opts.path_to_goma) 654 return _SetupAndRunPerformanceTest(config, opts.path_to_goma)
656 655
657 print ('Error: Could not load config file. Double check your changes to ' 656 print ('Error: Could not load config file. Double check your changes to '
658 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax errors.\n') 657 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax errors.\n')
659 return 1 658 return 1
660 659
661 660
662 if __name__ == '__main__': 661 if __name__ == '__main__':
663 sys.exit(main()) 662 sys.exit(main())
OLDNEW
« no previous file with comments | « tools/auto_bisect/request_build.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698