Replace builder_host and builder_port with builder_type.

Replace builder_host and builder_port with builder_type.

BUG=402669
Committed: https://crrev.com/38a6e5a6910ae2d4288d98edfee3736eae8b2dd0
Cr-Commit-Position: refs/heads/master@{#311065}

[qyearsley, 2015-01-09 22:34:14]

qyearsley@chromium.org changed reviewers:
+ prasadv@chromium.org

[RobertoCN, 2015-01-09 23:02:06]

robertocn@chromium.org changed reviewers:
+ robertocn@chromium.org

[RobertoCN, 2015-01-09 23:02:06]

LGTM with a single nit.

https://codereview.chromium.org/847603002/diff/1/tools/auto_bisect/bisect_per...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/847603002/diff/1/tools/auto_bisect/bisect_per...
tools/auto_bisect/bisect_perf_regression.py:198: builder_type: Builder type,
e.g. "perf".
Nit:

Will the list of acceptable builder_types be documented somewhere? If so, it
might be a good idea to point to such docco from this docstring. (Such as `refer
to constants defined in fetch_build...`)

[prasadv, 2015-01-09 23:23:17]

lgtm

[qyearsley, 2015-01-10 02:46:34]

On 2015/01/09 23:02:06, robertocn wrote:
> LGTM with a single nit.
> 
>
https://codereview.chromium.org/847603002/diff/1/tools/auto_bisect/bisect_per...
> File tools/auto_bisect/bisect_perf_regression.py (right):
> 
>
https://codereview.chromium.org/847603002/diff/1/tools/auto_bisect/bisect_per...
> tools/auto_bisect/bisect_perf_regression.py:198: builder_type: Builder type,
> e.g. "perf".
> Nit:
> 
> Will the list of acceptable builder_types be documented somewhere? If so, it
> might be a good idea to point to such docco from this docstring. (Such as
`refer
> to constants defined in fetch_build...`)

Excellent point -- the builder type constants are used in both fetch_build and
request_build -- so either one of these places seems appropriate, or a third
place. For now, the valid builder types are listed in fetch_build.py. Very soon
we'll likely want to add another one called something like "android-chrome".

[qyearsley, 2015-01-12 17:07:13]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2015-01-12 17:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/847603002/40001

[commit-bot: I haz the power, 2015-01-12 17:59:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-12 18:02:16]

Patchset 3 (id:??) landed as
https://crrev.com/38a6e5a6910ae2d4288d98edfee3736eae8b2dd0
Cr-Commit-Position: refs/heads/master@{#311065}