Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 847583002: Fix telemetry extension profile generator for OSX. (Closed)

Created:
5 years, 11 months ago by erikchen
Modified:
5 years, 11 months ago
Reviewers:
dtu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_profile_generation4_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix telemetry extension profile generator for OSX. This CL includes several functionality fixes to the extension profile creator, as well as several functionality improvements. - The URL to download extensions by identifier has changed, but the profile creator had not been updated. - Several of the extensions in many_extensions_profile_generator no longer exist, or no longer work. - There was a python error in _PrepareExtensionInstallFiles. - The old code waited 5 minutes for extensions to install. (And then waited for all tabs to load). The new code just waits 15 seconds, on the premise that it is better to fail fast than fail slow. - The old code required a clean installation of the OS, not connected to the corp network. The new code can be run from anywhere. Caveat: - This CL removes the ability to generate an extension profile on Linux. This is not a functional change, since the previous code was already broken. BUG=444230 Committed: https://crrev.com/300f7a40a8799dba69d39bfdc77f1d252b71ed0e Cr-Commit-Position: refs/heads/master@{#311584}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M tools/perf/profile_creators/extensions_profile_creator.py View 6 chunks +32 lines, -34 lines 0 comments Download
M tools/perf/profile_creators/many_extensions_profile_creator.py View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
erikchen
dtu: Please review.
5 years, 11 months ago (2015-01-09 22:50:04 UTC) #4
dtu
lgtm
5 years, 11 months ago (2015-01-14 22:53:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847583002/40001
5 years, 11 months ago (2015-01-14 23:12:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-15 00:20:36 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:22:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/300f7a40a8799dba69d39bfdc77f1d252b71ed0e
Cr-Commit-Position: refs/heads/master@{#311584}

Powered by Google App Engine
This is Rietveld 408576698