Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/operation/ReconcileWorkingCopyOperation.java

Issue 8475008: Catch compilation exceptions in another location and make it more clear when a log entry represen... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/operation/ReconcileWorkingCopyOperation.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/operation/ReconcileWorkingCopyOperation.java (revision 1212)
+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/operation/ReconcileWorkingCopyOperation.java (working copy)
@@ -123,7 +123,12 @@
// reconcileFlags,
// progressMonitor);
List<DartCompilationError> parseErrors = new ArrayList<DartCompilationError>();
- ast = DartCompilerUtilities.resolveUnit(source, parseErrors);
+ try {
+ ast = DartCompilerUtilities.resolveUnit(source, parseErrors);
+ } catch (Exception exception) {
+ DartCore.logInformation("Could not reconcile \""
+ + source.getCorrespondingResource().getLocation() + "\"", exception);
+ }
convertErrors(parseErrors, problems);
if (progressMonitor != null) {
progressMonitor.worked(1);
« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698