Issue 847453002: Files.app: Fix closure compiler errors.

Issue 847453002: Files.app: Fix closure compiler errors. (Closed)

Created:
5 years, 11 months ago by hirono

Modified:
5 years, 11 months ago

Reviewers:
fukino

CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Files.app: Fix closure compiler errors. BUG=NONE TEST=NONE Committed: https://crrev.com/d9720f3870d6e3281e0614ba561422978d61f4b0 Cr-Commit-Position: refs/heads/master@{#310744}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	third_party/closure_compiler/externs/file_manager_private.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

fukino

On 2015/01/09 08:23:46, hirono wrote: > PTAL, thanks! lgtm!

5 years, 11 months ago (2015-01-09 08:24:35 UTC) #3

hirono

On 2015/01/09 08:24:35, fukino wrote: > On 2015/01/09 08:23:46, hirono wrote: > > PTAL, thanks! ...

5 years, 11 months ago (2015-01-09 08:25:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847453002/1

5 years, 11 months ago (2015-01-09 08:25:23 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-09 09:10:51 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d9720f3870d6e3281e0614ba561422978d61f4b0
Cr-Commit-Position: refs/heads/master@{#310744}