Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 847443003: rename blitrow::proc and add (uncalled) hook for colorproc16 (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
mlee, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

rename blitrow::proc and add (uncalled) hook for colorproc16 BUG=skia:3302 Committed: https://skia.googlesource.com/skia/+/a7f11918d92621507f35b228a290f05dcaf0f4b6

Patch Set 1 #

Patch Set 2 : arm fix #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -47 lines) Patch
M include/core/SkBlitRow.h View 3 chunks +22 lines, -15 lines 0 comments Download
M src/core/SkBlitRow_D16.cpp View 2 chunks +55 lines, -12 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBlitRow_opts_mips_dsp.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_none.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/opts/opts_check_x86.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
reed1
suggested precursor for https://codereview.chromium.org/845293002/
5 years, 11 months ago (2015-01-13 15:10:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847443003/1
5 years, 11 months ago (2015-01-13 15:11:20 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-13 15:11:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1428)
5 years, 11 months ago (2015-01-13 15:13:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847443003/20001
5 years, 11 months ago (2015-01-13 15:37:20 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-13 15:37:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1431)
5 years, 11 months ago (2015-01-13 15:39:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847443003/40001
5 years, 11 months ago (2015-01-13 16:22:30 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-13 16:22:31 UTC) #15
reed1
ptal
5 years, 11 months ago (2015-01-13 21:39:18 UTC) #16
djsollen
Lgtm, but instead of #if 0 in the blitter put the specialized version as a ...
5 years, 11 months ago (2015-01-13 21:49:52 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:51:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a7f11918d92621507f35b228a290f05dcaf0f4b6

Powered by Google App Engine
This is Rietveld 408576698