Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: sky/engine/core/frame/FrameView.cpp

Issue 847393003: Remove the PaintInvalidation DocumentLifeCycle states. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/FrameView.cpp
diff --git a/sky/engine/core/frame/FrameView.cpp b/sky/engine/core/frame/FrameView.cpp
index 5849378a4d6feaadfa04b82581e0f9b3bdc8c53c..a6f39c2bd1d7c9e26670b319dc86e7dd830de05e 100644
--- a/sky/engine/core/frame/FrameView.cpp
+++ b/sky/engine/core/frame/FrameView.cpp
@@ -393,13 +393,6 @@ void FrameView::layout(bool allowSubtree)
frame().page()->chrome().client().layoutUpdated(m_frame.get());
}
-// FIXME(sky): Remove
-void FrameView::invalidateTreeIfNeeded()
-{
- lifecycle().advanceTo(DocumentLifecycle::InPaintInvalidation);
- lifecycle().advanceTo(DocumentLifecycle::PaintInvalidationClean);
-}
-
DocumentLifecycle& FrameView::lifecycle() const
{
return m_frame->document()->lifecycle();
@@ -738,7 +731,7 @@ void FrameView::paintContents(GraphicsContext* p, const IntRect& rect)
}
RELEASE_ASSERT(!needsLayout());
- ASSERT(document->lifecycle().state() >= DocumentLifecycle::PaintInvalidationClean);
+ ASSERT(document->lifecycle().state() >= DocumentLifecycle::StyleAndLayoutClean);
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Paint", "data", InspectorPaintEvent::data(renderView, rect));
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", TRACE_EVENT_SCOPE_PROCESS, "stack", InspectorCallStackEvent::currentCallStack());
@@ -795,12 +788,12 @@ void FrameView::updateLayoutAndStyleForPainting()
updateLayoutAndStyleIfNeededRecursive();
if (RenderView* view = renderView()) {
- TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "InvalidateTreeAndUpdateIframes", TRACE_EVENT_SCOPE_PROCESS, "frame", m_frame.get());
- invalidateTreeIfNeeded();
+ TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "updateIFramesAfterLayout", TRACE_EVENT_SCOPE_PROCESS, "frame", m_frame.get());
view->updateIFramesAfterLayout();
}
- ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean);
+ // TODO(ojan): Get rid of this and just have the LayoutClean state.
+ lifecycle().advanceTo(DocumentLifecycle::StyleAndLayoutClean);
DocumentAnimations::startPendingAnimations(*m_frame->document());
}
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698