Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 847333004: Move parts from enterprise.platformKeysInternal to platformKeysInternal for reuse. (Closed)

Created:
5 years, 11 months ago by pneubeck (no reviews)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cert_idl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move parts from enterprise.platformKeysInternal to platformKeysInternal for reuse. This moves the functions - NormalizeAlgorithm from enterprise_platform_keys_natives to platform_keys_natives - sign from enterprise.platformKeysInternal to platformKeysInternal . Both will be reused by the new platformKeys API. platformKeysInternal will then be extended about the internal selectClientCertificates function that is needed for platformKeys. No functional changes. TBR=arv@chromium.org BUG=450167 NOPRESUBMIT=true Committed: https://crrev.com/433f9f9ac6f32f0e842ce8355faa5c613ad6ffc8 Cr-Commit-Position: refs/heads/master@{#313016}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -532 lines) Patch
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.h View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc View 8 chunks +11 lines, -90 lines 0 comments Download
A chrome/browser/extensions/api/platform_keys/platform_keys_api.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/enterprise_platform_keys_internal.idl View 1 chunk +0 lines, -19 lines 0 comments Download
A chrome/common/extensions/api/platform_keys_internal.idl View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 5 chunks +10 lines, -9 lines 0 comments Download
D chrome/renderer/extensions/enterprise_platform_keys_natives.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/renderer/extensions/enterprise_platform_keys_natives.cc View 1 chunk +0 lines, -116 lines 0 comments Download
A + chrome/renderer/extensions/platform_keys_natives.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/renderer/extensions/platform_keys_natives.cc View 2 chunks +4 lines, -5 lines 0 comments Download
D chrome/renderer/resources/extensions/enterprise_platform_keys/key.js View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/renderer/resources/extensions/enterprise_platform_keys/key_pair.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js View 3 chunks +19 lines, -61 lines 0 comments Download
D chrome/renderer/resources/extensions/enterprise_platform_keys/utils.js View 1 chunk +0 lines, -16 lines 0 comments Download
A + chrome/renderer/resources/extensions/platform_keys/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/renderer/resources/extensions/platform_keys/internal_api.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/renderer/resources/extensions/platform_keys/key.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/renderer/resources/extensions/platform_keys/subtle_crypto.js View 4 chunks +10 lines, -76 lines 0 comments Download
A + chrome/renderer/resources/extensions/platform_keys/utils.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (15 generated)
pneubeck (no reviews)
ptal this relates to what we discussed in chat. The future dependencies will be enterprise.platformKeys ...
5 years, 11 months ago (2015-01-20 09:41:55 UTC) #8
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-20 18:49:21 UTC) #9
pneubeck (no reviews)
arv@chromium.org: Please review changes in chrome/renderer/resources/renderer_resources.grd asvitkine@chromium.org: Please review changes in extension_function_histogram_value.h
5 years, 11 months ago (2015-01-22 10:36:07 UTC) #13
Alexei Svitkine (slow)
https://codereview.chromium.org/847333004/diff/100001/extensions/browser/extension_function_histogram_value.h File extensions/browser/extension_function_histogram_value.h (right): https://codereview.chromium.org/847333004/diff/100001/extensions/browser/extension_function_histogram_value.h#newcode838 extensions/browser/extension_function_histogram_value.h:838: PLATFORMKEYSINTERNAL_SIGN, Please update histograms.xml too.
5 years, 11 months ago (2015-01-22 15:16:48 UTC) #14
pneubeck (no reviews)
https://codereview.chromium.org/847333004/diff/100001/extensions/browser/extension_function_histogram_value.h File extensions/browser/extension_function_histogram_value.h (right): https://codereview.chromium.org/847333004/diff/100001/extensions/browser/extension_function_histogram_value.h#newcode838 extensions/browser/extension_function_histogram_value.h:838: PLATFORMKEYSINTERNAL_SIGN, On 2015/01/22 15:16:48, Alexei Svitkine wrote: > Please ...
5 years, 11 months ago (2015-01-22 15:48:26 UTC) #15
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-22 16:36:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847333004/140001
5 years, 11 months ago (2015-01-24 10:37:36 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/52097) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/17197) Try ...
5 years, 11 months ago (2015-01-24 10:40:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847333004/160001
5 years, 11 months ago (2015-01-24 10:49:42 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38145) Try jobs failed on following ...
5 years, 11 months ago (2015-01-24 10:55:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847333004/160001
5 years, 11 months ago (2015-01-24 10:59:39 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:160001)
5 years, 11 months ago (2015-01-24 11:45:06 UTC) #27
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 11:46:00 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/433f9f9ac6f32f0e842ce8355faa5c613ad6ffc8
Cr-Commit-Position: refs/heads/master@{#313016}

Powered by Google App Engine
This is Rietveld 408576698